feat: cache transaction receipts #2181
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…e into fs-1093/cache-tx-receipt
dewanshparashar
commented
Jan 13, 2025
| import { BigNumber } from 'ethers' | ||
|
|
||
| const cacheKey = `arbitrum:bridge:tx-receipts` | ||
| const cacheLogs = false |
There was a problem hiding this comment.
to be removed when ready for review
dewanshparashar
commented
Jan 13, 2025
| @@ -107,7 +108,8 @@ const getProviderForChainCache: { | |||
|
|
|||
| function createProviderWithCache(chainId: ChainId) { | |||
There was a problem hiding this comment.
getProviderForChainId's provider is passed down to almost everywhere in the code, especially in Tx history. Hence, changing this provider to EnhancedProvider should upgrade it across our codebase.
…e into fs-1093/cache-tx-receipt
…e into fs-1093/cache-tx-receipt
…e into fs-1093/cache-tx-receipt
…e into fs-1093/cache-tx-receipt
spsjvc
reviewed
Jan 17, 2025
|
|
||
| const cacheKey = `arbitrum:bridge:tx-receipts-cache` | ||
| const enableCaching = true | ||
|
|
There was a problem hiding this comment.
txReceiptToString(txReceipt: TransactionReceipt): string
txReceiptFromString(stringified: string): TransactionReceipt
|
|
||
| type CachedReceipts = Record<string, TransactionReceipt> | ||
|
|
||
| const cacheKey = `arbitrum:bridge:tx-receipts-cache` |
There was a problem hiding this comment.
Suggested change
| const cacheKey = `arbitrum:bridge:tx-receipts-cache` | |
| const localStorageKey = `arbitrum:bridge:tx-receipts-cache` |
| if (!enableCaching) return false | ||
|
|
||
| // Don't cache failed transactions | ||
| if (typeof txReceipt.status !== 'undefined' && txReceipt.status === 0) { |
There was a problem hiding this comment.
Suggested change
| if (typeof txReceipt.status !== 'undefined' && txReceipt.status === 0) { | |
| if (txReceipt.status === 0) { |
| // Finality checks to avoid caching re-org'ed transactions | ||
| if ( | ||
| (chainId === ChainId.Ethereum && txReceipt.confirmations < 65) || | ||
| (chainId === ChainId.Sepolia && txReceipt.confirmations < 5) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.