Merge pull request #13 from Oefenweb/improved-pip-download-url

Improved pip download url

.ansible-lint

@@ -1,2 +1,3 @@
 warn_list:
   - '106'
+  - '306'

tasks/main.yml

@@ -23,6 +23,70 @@
     - pip
     - pip-directory
 
+- name: get python version
+  shell: >
+    python{{ pip_python_version | string }} --version 2>&1 | awk '{print $2}'
+  register: _python_version
+  changed_when: false
+  tags:
+    - configuration
+    - pip
+    - pip-get-python-version
+
+- block:
+
+    - name: get download url (2.6)
+      set_fact:
+        pip_download_url: 'https://bootstrap.pypa.io/2.6/get-pip.py'
+      when:
+        - _python_version.stdout is version('2.6', '>=')
+        - _python_version.stdout is version('2.7', '<')
+
+    - name: get download url (2.7)
+      set_fact:
+        pip_download_url: 'https://bootstrap.pypa.io/2.7/get-pip.py'
+      when:
+        - _python_version.stdout is version('2.7', '>=')
+        - _python_version.stdout is version('2.8', '<')
+
+    - name: get download url (3.2)
+      set_fact:
+        pip_download_url: 'https://bootstrap.pypa.io/3.2/get-pip.py'
+      when:
+        - _python_version.stdout is version('3.2', '>=')
+        - _python_version.stdout is version('3.3', '<')
+
+    - name: get download url (3.3)
+      set_fact:
+        pip_download_url: 'https://bootstrap.pypa.io/3.3/get-pip.py'
+      when:
+        - _python_version.stdout is version('3.3', '>=')
+        - _python_version.stdout is version('3.4', '<')
+
+    - name: get download url (3.4)
+      set_fact:
+        pip_download_url: 'https://bootstrap.pypa.io/3.4/get-pip.py'
+      when:
+        - _python_version.stdout is version('3.4', '>=')
+        - _python_version.stdout is version('3.5', '<')
+
+    - name: get download url (3.5)
+      set_fact:
+        pip_download_url: 'https://bootstrap.pypa.io/3.5/get-pip.py'
+      when:
+        - _python_version.stdout is version('3.5', '>=')
+        - _python_version.stdout is version('3.6', '<')
+
+    - name: get download url (latest)
+      set_fact:
+        pip_download_url: 'https://bootstrap.pypa.io/get-pip.py'
+      when: _python_version.stdout is version('3.6', '>=')
+
+  tags:
+    - configuration
+    - pip
+    - pip-get-download-url
+
 - name: download (latest) pip
   get_url:
     url: "{{ pip_download_url }}"

tests/test.yml

@@ -3,7 +3,12 @@
 - hosts: localhost
   connection: local
   become: true
+  pre_tasks:
+    - name: include variables
+      include_vars: "{{ item }}"
+      with_first_found:
+        - "{{ playbook_dir }}/vars/_{{ ansible_distribution_release }}.yml"
+        - "{{ playbook_dir }}/vars/_{{ ansible_distribution | lower }}.yml"
+        - "{{ playbook_dir }}/vars/_default.yml"
   roles:
     - ../../
-#  vars:
-#    pip_python_version: 3

tests/vagrant.yml

@@ -3,5 +3,12 @@
 - hosts: all
   remote_user: vagrant
   become: true
+  pre_tasks:
+    - name: include variables
+      include_vars: "{{ item }}"
+      with_first_found:
+        - "{{ playbook_dir }}/vars/_{{ ansible_distribution_release }}.yml"
+        - "{{ playbook_dir }}/vars/_{{ ansible_distribution | lower }}.yml"
+        - "{{ playbook_dir }}/vars/_default.yml"
   roles:
     - ../../

vars/main.yml

@@ -6,4 +6,3 @@ pip_dependencies:
   - curl
 
 pip_download_path: /var/lib/ansible/pip/downloads
-pip_download_url: "https://bootstrap.pypa.io/{{ pip_python_version is version('3', '>=') | ternary('', '2.7') }}/get-pip.py"