Add xFrameOptions configure option and deprecate xFrameOptionAllowFrom (

#510) Added XFrameOptions
OctopusDeploy · Mar 6, 2020 · 2448148 · 2448148
1 parent abcebd9
commit 2448148
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/...Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt b/...Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt
@@ -5234,8 +5234,10 @@ Octopus.Client.Model
   class XOptionsResource
   {
     static System.String XFrameAllowFromDescription
+    static System.String XFrameOptionsDescription
     .ctor()
     String XFrameOptionAllowFrom { get; set; }
+    String XFrameOptions { get; set; }
   }
 }
 Octopus.Client.Model.Accounts

diff --git a/.../PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt b/.../PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt
@@ -5258,8 +5258,10 @@ Octopus.Client.Model
   class XOptionsResource
   {
     static System.String XFrameAllowFromDescription
+    static System.String XFrameOptionsDescription
     .ctor()
     String XFrameOptionAllowFrom { get; set; }
+    String XFrameOptions { get; set; }
   }
 }
 Octopus.Client.Model.Accounts

diff --git a/source/Octopus.Client/Model/WebPortalConfigurationResource.cs b/source/Octopus.Client/Model/WebPortalConfigurationResource.cs
@@ -45,9 +45,14 @@ public class WebPortalSecurityResource
 
     public class XOptionsResource
     {
-        public const string XFrameAllowFromDescription = "A uri to provide in the X-Frame-Option http header in conjunction with the ALLOW-FROM value.";
+        public const string XFrameAllowFromDescription = "(Deprecated) A uri to provide in the X-Frame-Option http header in conjunction with the ALLOW-FROM value.";
+        public const string XFrameOptionsDescription = "Provide in the X-Frame-Option http header a directive such as sameorigin or deny.";
+
 
         [Writeable]
         public string XFrameOptionAllowFrom { get; set; }
+
+        [Writeable]
+        public string XFrameOptions { get; set; }
     }
 }