Skip to content

Commit

Permalink
Fix nested shadow updates (#29)
Browse files Browse the repository at this point in the history 
* Fix nested shadow updates

* add export

* fix typecheck

* fix types

* disable unsupported test for now

* pre-update functions should also run for the parents of nested updates

* fix type

* fixup! pre-update functions should also run for the parents of nested updates

* fixup! pre-update functions should also run for the parents of nested updates
  • Loading branch information
@Octogonapus
Octogonapus authored Feb 13, 2025
1 parent fa23db7 commit 6346f1a
Show file tree
Hide file tree
Showing 5 changed files with 441 additions and 174 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "AWSCRT"
uuid = "df31ea59-17a4-4ebd-9d69-4f45266dc2c7"
version = "0.4.2"
version = "0.5.0"

[deps]
CountDownLatches = "621fb831-fdad-4fff-93ac-1af7b7ed19e3"
Expand Down
1 change: 1 addition & 0 deletions src/AWSCRT.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export OnShadowMessage

include("ShadowFramework.jl")
export ShadowFramework
export ShadowDocumentPropertyPreUpdateFunction
export ShadowDocumentPropertyUpdateCallback
export ShadowDocumentPreUpdateCallback
export ShadowDocumentPostUpdateCallback
Expand Down
Loading

4 comments on commit 6346f1a

@Octogonapus
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/125031

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.5.0 -m "<description of version>" 6346f1a8787411abbd9aa2bf5676978e0a8ce440
git push origin v0.5.0

@Octogonapus
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

Release notes:

Breaking changes

  • Removes structs as shadow documents. All shadow documents are now dicts.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/125031

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.5.0 -m "<description of version>" 6346f1a8787411abbd9aa2bf5676978e0a8ce440
git push origin v0.5.0

Please sign in to comment.