Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add py310 to integration test matrix #1771

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

VeckoTheGecko
Copy link
Contributor

In #1769 (review) there was some py310 incompatible code. Adding py310 to integration test matrix so that it fails in CI in future.

@VeckoTheGecko
Copy link
Contributor Author

VeckoTheGecko commented Nov 25, 2024

Sidenote: @erikvansebille Is the purpose of the integration tests to make sure that the tutorials are working correctly, or to actually test the codebase? If the former, how do you feel about removing windows and mac from the integration tests? (as windows/mac incompatibility should arise in the unit tests)

Has Windows integration tests failed by themselves before?

If we're unsure perhaps we should lean towards keeping

@erikvansebille
Copy link
Member

Has Windows integration tests failed by themselves before?

Yes, if I remember well this has happened on the docs/examples/example_dask_chunk_OCMs.py test before; but these are rather flaky anyways (they also failed recently with a new array version in #1762). So I think these integration tests are more for external dependency deprecations than our own code-development

If we're unsure perhaps we should lean towards keeping

We could perhaps run the windows and macOS integration tests only every month or so. That will reduce our CI-burden (and save some energy).

@VeckoTheGecko
Copy link
Contributor Author

if I remember well this has happened on the docs/examples/example_dask_chunk_OCMs.py

I see. I thought that integration tests were just the notebooks.

@erikvansebille
Copy link
Member

erikvansebille commented Nov 25, 2024

I see. I thought that integration tests were just the notebooks.

No, the notebooks (but only those that don't start with documentation_) and the docs/examples/*.py files

@VeckoTheGecko
Copy link
Contributor Author

Yes. Though technically the __main__ parts of the docs/examples/example*.py scripts are unit tests since test_example_script() is in tests/test_examples.py.

What has been the rule of thumb for whether something is a unit or integration test?

@erikvansebille
Copy link
Member

What has been the rule of thumb for whether something is a unit or integration test?

The integration tests use 'real-world' hydrodynamic datasets (GlobCurrent, MITgcm, OFAM, ...) and/or are full-fledged example simulations (e.g. Peninsula, Stommel, Brownian).

@VeckoTheGecko VeckoTheGecko merged commit 1f4ae4e into master Nov 25, 2024
15 checks passed
@VeckoTheGecko VeckoTheGecko deleted the v/ci-int-matrix branch November 25, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants