-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add py310 to integration test matrix #1771
Conversation
Sidenote: @erikvansebille Is the purpose of the integration tests to make sure that the tutorials are working correctly, or to actually test the codebase? If the former, how do you feel about removing Has Windows integration tests failed by themselves before? If we're unsure perhaps we should lean towards keeping |
db96591
to
ee7bbe0
Compare
Yes, if I remember well this has happened on the docs/examples/example_dask_chunk_OCMs.py test before; but these are rather flaky anyways (they also failed recently with a new array version in #1762). So I think these integration tests are more for external dependency deprecations than our own code-development
We could perhaps run the windows and macOS integration tests only every month or so. That will reduce our CI-burden (and save some energy). |
I see. I thought that integration tests were just the notebooks. |
No, the notebooks (but only those that don't start with |
Yes. Though technically the What has been the rule of thumb for whether something is a unit or integration test? |
The integration tests use 'real-world' hydrodynamic datasets (GlobCurrent, MITgcm, OFAM, ...) and/or are full-fledged example simulations (e.g. Peninsula, Stommel, Brownian). |
ee7bbe0
to
92f730c
Compare
In #1769 (review) there was some py310 incompatible code. Adding py310 to integration test matrix so that it fails in CI in future.