-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API changes: particlefile.py
and other touchups
#1727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeckoTheGecko
force-pushed
the
v/api
branch
2 times, most recently
from
October 10, 2024 11:19
961bbb3
to
a45a6ab
Compare
VeckoTheGecko
changed the title
[WIP] API changes
API changes: Oct 14, 2024
particlefile.py
and other touchups
Once this is merged, I'll do some testing with the team, and then we're good to do a release (from the API POV) |
erikvansebille
approved these changes
Oct 16, 2024
mark ParticleFile.add_metadat() for removal mark ParticleFile.write_once() as private
create_new_zarrfile outputdt chunks particleset fname
vars_to_write time_origin
parcels_mesh maxids pids_written mpi_rank fill_value_map analytical
lon_grid_to_target() lon_remapping lon_grid_to_source() lon_particle_to_target()
name to_write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1695
Changes
This PR makes many of the names in
particlefile.py
(and some other files):All privatisations/removals are done in a non-breaking way, raising a deprecation warning.
The method/attributes affected are: