Improve helm docs and network migration #151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds --validate=false flag to kubectl commands in the ENR job to prevent validation errors when running in FIPS 140-only mode environments. Issue: When the ENR generation job runs in FIPS 140-only mode, kubectl validation fails with error: "crypto/ecdh: use of X25519 is not allowed in FIPS 140-only mode" This occurs during: 1. kubectl apply when creating new ENR secrets 2. kubectl patch when updating existing secrets with missing ENR field Solution: Add --validate=false flag to both kubectl commands (lines 210, 226): - kubectl patch: --validate=false flag added - kubectl apply: --validate=false flag added The GODEBUG environment variable (x509sha1=1,tls13=0) is already set for the kubectl-secret-creator container, but validation needs to be explicitly disabled for kubectl operations in FIPS mode. This allows the ENR job to complete successfully in FIPS-compliant Kubernetes clusters while maintaining the same functional behavior.
This commit includes several documentation and usability improvements: 1. Migrate from chainId to network parameter (breaking change) - Replace all chainId references with network parameter in docs - Update QUICKSTART.md examples: chainId=1 → network=mainnet - Update values-examples to use network instead of chainId - Templates already supported network-based helpers 2. Update all Helm commands to use 'helm upgrade --install' - Updated 8+ instances in README.md - Provides idempotent commands for both install and upgrade scenarios - Better user experience and less confusion 3. Add Challenge & Testing documentation - New comprehensive section in QUICKSTART.md - Examples for overriding API endpoints (dev/staging) - Examples for using specific DKG sidecar commits/branches - Complete challenge example with all parameters - Helpful for testing and development workflows 4. Implement intelligent fallback beacon node endpoints - Auto-select publicnode.com endpoints based on network - mainnet → ethereum-beacon-api.publicnode.com - sepolia → ethereum-sepolia-beacon-api.publicnode.com - hoodi → ethereum-hoodi-beacon-api.publicnode.com - Pods can now start without manual fallback configuration - Users can still override with custom endpoints Files modified: - charts/dv-pod/QUICKSTART.md - charts/dv-pod/README.md - charts/dv-pod/README.md.gotmpl - charts/dv-pod/templates/_helpers.tpl - charts/dv-pod/templates/statefulset.yaml - charts/dv-pod/values-examples/with-target-config-hash.yaml - charts/dv-pod/values.yaml BREAKING CHANGE: Users must now use --set network=mainnet instead of --set chainId=1
bussyjd
force-pushed
the
improve-helm-docs-and-network-migration
branch
from
ac54e58 to
54bc95f
Compare
bussyjd
added a commit
that referenced
this pull request
Nov 13, 2025
Contributor
Author
|
Consolidated into #152 along with other workshop improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.