Enhance validator client type validation with actionable error messages #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the validator client type validation error messages to provide better user guidance when invalid types are specified. Changes: - Add generic fuzzy matching for "did you mean" suggestions * Known typos map: loki→lodestar, prism→prysm, lighthose→lighthouse * Prefix matching: tek→teku, nim→nimbus, lodest→lodestar * Substring matching for partial matches - Provide actionable fix instructions showing: * CLI flag syntax: --set validatorClient.type=<type> * values.yaml format with proper indentation * Custom values file approach - Include documentation reference to README.md - Use suggested type in examples when available Example error output: ERROR: Invalid validator client type 'loki'. Valid options: lighthouse, lodestar, teku, prysm, nimbus⚠️ Did you mean 'lodestar'? How to fix this: • Using --set flag: --set validatorClient.type=lodestar • In your values.yaml file: validatorClient: type: lodestar Tested with all validator client types and various typos. All valid types (lighthouse, lodestar, teku, prysm, nimbus) still work correctly. Addresses user feedback from PR #148 that validation errors needed more actionable guidance.
Contributor
Author
|
Consolidated into #152 along with other workshop improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the validator client type validation error messages to provide better user guidance when invalid types are specified.
Changes:
Example error output:
ERROR: Invalid validator client type 'loki'.
Valid options: lighthouse, lodestar, teku, prysm, nimbus
How to fix this: • Using --set flag: --set validatorClient.type=lodestar
Tested with all validator client types and various typos. All valid types (lighthouse, lodestar, teku, prysm, nimbus) still work correctly.
Addresses user feedback from PR #148 that validation errors needed more actionable guidance.