Skip to content

Conversation

@DiogoSantoss
Copy link
Contributor

@DiogoSantoss DiogoSantoss commented Oct 21, 2025

Proxied requests from the VC to the BN didn't have our eth2wrap logic (such as sending to multiple BNs or retrying to fallback nodes) neither did they send our additional headers from CHARON_BEACON_NODE_HEADERS.
This changes our proxy to use the eth2wrap client to proxy to (possibly) multiple addresses instead of directly proxing to a single address.

category: feature
ticket: none

@DiogoSantoss DiogoSantoss self-assigned this Oct 21, 2025
@DiogoSantoss DiogoSantoss force-pushed the diogo/use-eth2wrap-in-proxy branch from 4e4e938 to 973b9e4 Compare October 21, 2025 14:33
@DiogoSantoss DiogoSantoss force-pushed the diogo/use-eth2wrap-in-proxy branch from 9c4a472 to 4a4e409 Compare October 22, 2025 08:54
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 57.74648% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.82%. Comparing base (bba43cd) to head (6350da8).

Files with missing lines Patch % Lines
app/eth2wrap/httpwrap.go 61.05% 31 Missing and 6 partials ⚠️
app/eth2wrap/eth2wrap.go 8.00% 23 Missing ⚠️
core/validatorapi/router.go 66.03% 14 Missing and 4 partials ⚠️
app/eth2wrap/multi.go 73.52% 6 Missing and 3 partials ⚠️
app/eth2wrap/lazy.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4042      +/-   ##
==========================================
+ Coverage   53.80%   53.82%   +0.01%     
==========================================
  Files         242      242              
  Lines       39425    39594     +169     
==========================================
+ Hits        21214    21312      +98     
- Misses      15967    16033      +66     
- Partials     2244     2249       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

Copy link
Collaborator

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the build is broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants