Feature/192 #193

KoolTheba · 2020-03-22T18:37:12Z

⚠️ WIP please no merge!

IMPORTANT

This PR should not be merged before Lerna Implementation #187
This PR is not yet ready to merge; please check Backlog 👇
@ckarande @UlisesGascon @lirantal As this PR is going to be quite long, please start review it even if it is not yet finished and provide feedback 🙏
The scope of this PR is to cover just the feature Benefits without DB but including testing, mocking, Docker, CI, etc...so this PR will determine how we are going to develop new features in the React API Rest app sample
Note: CI still broken due Lerna Implementation #187 current situation (cc: @UlisesGascon), so that part is going to be solved in Lerna Implementation #187. Once that is ready, I'll pull the changes to this current PR.

PR Backlog (see #192)

Notable changes

React api

Added autogenerated express project (0f3fb39, 9ba3401)
Upgraded dependencies (f7aebe7)

 cookie-parser   ~1.4.4  →   ~1.4.5
 debug           ~2.6.9  →   ~4.1.1
 express        ~4.16.1  →  ~4.17.1
 http-errors     ~1.6.3  →   ~1.7.3
 morgan          ~1.9.1  →  ~1.10.0

Added config files (8b1884d)
- Added depedency [email protected]
Updated gitignore rules (5034336)
ES6 migration (0efe7f0, 49493d9)
Added standard linter (67cefa0, d316b82 & bcaf6ef)
- Added dev dependency [email protected]
Added test environment (414e602, 83e6b58)
- Added dev dependencies [email protected] & [email protected]
Update linting rules (00bc5f3)
Added initial tests (e591970)

React client

Added autogenerated react app (8fd44fb)
Upgrade testing dependencies (fed2529)

@testing-library/jest-dom    ^4.2.4  →   ^5.1.1
@testing-library/react       ^9.3.2  →  ^10.0.1
@testing-library/user-event  ^7.1.2  →  ^10.0.0

Added linter to project (a24718b, b77296b & 780c963)
Npm tasks for testing (fc07d62)
Added styled component & material UI (2f07bf1)
Added material ui icons (25addff)
Updated app component (5731cd9)

Changelog

8fd44fb feat(react client): added autogenerated react app by @KoolTheba
0f3fb39 feat(react api): added autogenerated express project by @KoolTheba
f7aebe7 chore(react api): upgraded dependencies by @KoolTheba
8b1884d feat(react api): added config files by @KoolTheba
5034336 chore(files): updated gitignore rules by @KoolTheba
9ba3401 fix(react api): project name by @KoolTheba
0efe7f0 refactor(react api): ES6 migration by @KoolTheba
49493d9 refactor(react api): ES6 migration by @KoolTheba
67cefa0 feat(react api): added standard linter by @KoolTheba
d316b82 feat(react api): added lint git hook by @KoolTheba
bcaf6ef chore(react api): files linted by @KoolTheba
414e602 feat(react api): added test environment by @KoolTheba
83e6b58 feat(react api): added test git hook by @KoolTheba
00bc5f3 chore(react api): update linting rules by @KoolTheba
e591970 feat(react api): added initial tests by @KoolTheba
fed2529 chore(react client): upgrade testing dependencies by @KoolTheba
a24718b feat(react client): added linter to project by @KoolTheba
b77296b feat(react client): added npm tasks for linting by @KoolTheba
780c963 chore(react client): files linted by @KoolTheba
fc07d62 WIP(react client): npm tasks for testing by @KoolTheba
2f07bf1 feat(react client): added styled component & material UI by @KoolTheba
25addff feat(react client): added material ui icons by @KoolTheba
5731cd9 feat(react client): updated app component by @KoolTheba

Related OWASP#192

- Related OWASP#192 ``` cookie-parser ~1.4.4 → ~1.4.5 debug ~2.6.9 → ~4.1.1 express ~4.16.1 → ~4.17.1 http-errors ~1.6.3 → ~1.7.3 morgan ~1.9.1 → ~1.10.0 ```

- Related OWASP#192 - Added depedency `[email protected]` - Added main config file

See: https://www.gitignore.io/api/node,code,linux,macos,windows,webstorm,sublimetext

Related OWASP#192

- Related OWASP#192 - Added dev dependency `[email protected]` - Added npm tasks for linting

Related OWASP#192

- Related OWASP#192 - Added dev dependencies `[email protected]` & `[email protected]` - Added npm tasks for testing

Related OWASP#192

- Updated testing dependencies ``` @testing-library/jest-dom ^4.2.4 → ^5.1.1 @testing-library/react ^9.3.2 → ^10.0.1 @testing-library/user-event ^7.1.2 → ^10.0.0 ```

- Related OWASP#192

- Added jest to eslint rules - Linted files

- Related OWASP#192 - Added watch and CI support - Missing coverage and snapshot update

Related OWASP#192

lirantal · 2023-03-06T10:01:06Z

Hey @KoolTheba this is awesome!
I'm going to push in a bunch of small but needed changes and updates to the codebase and your PR would be great as another follow-up. I know we're like 2 years late here but would you like to keep working on pushing it in? :-)

KoolTheba · 2023-03-06T18:23:31Z

Hi @lirantal !
It would be great to collaborate with whatever you need! And for sure, this PR can be a perfect push!
I can have a look also with @UlisesGascon this week and we can align the 3 of us on the next steps for this PR and for stuff next to come. The plan here, as far as I remember, was to migrate the current web to new stack with React and Express.

lirantal · 2023-03-06T20:58:39Z

@KoolTheba when and if we do that migration - will it come with the exact same set of vulnerabilities in the new stack?

KoolTheba · 2023-03-19T16:41:31Z

Hi @lirantal !
I've sent you a couple of messages in Slack :-)
I've said that I wanted to clarify some details. When you mention the exact same set of vulnerabilities you mean that you are thinking about adding more to the top 10 or vulnerabilities of the libraries as dependencies? According to the second one, we can stick to the stack chosen 2 years ago. I'd just upgrade React to the latest and maybe use NextJS, and probably, but on this @UlisesGascon can confirm, we could use Turborepo instead of Lerna.

lirantal · 2023-04-02T08:35:42Z

@KoolTheba apologies, hard to keep up with many slacks and GitHub notifications.

So what I mean is that we should maintain the current state of vulnerabilities as is demoed on the NodeGoat project right now. It is ok if we have different ways to exploit them, but the same set of vulnerabilities that are documented today in the project's tutorial should be kept.

Is that the case for this PR?

lirantal · 2023-07-17T08:35:14Z

ping @KoolTheba

KoolTheba · 2023-08-04T16:48:26Z

Hi @lirantal !
Thanks for the clarification!
Even if this PR is about changes in the stack, the same set of vulnerabilities will remain the same, as demoed in the past.

lirantal · 2023-08-04T17:21:26Z

Thanks for replying. I wasn't participating at the time it was demo'ed. Any chance there's a recording that easily verifies that?

KoolTheba · 2023-08-13T09:51:41Z

Hi @lirantal !
By demoed I meant the original video demos of the project that can be found here 😃 https://www.youtube.com/@owaspnodegoatproject910/videos

I'm going to push in a bunch of small but needed changes and updates to the codebase and your PR would be great as another follow-up. I know we're like 2 years late here but would you like to keep working on pushing it in? :-)

If you want to take leadership on it, feel free to add the changes you mentioned. And if you need a contributor/maintainer, let me know, very happy to collaborate with you if you guide the next iteration.

KoolTheba added 23 commits March 21, 2020 17:09

feat(react client): added autogenerated react app

8fd44fb

Related OWASP#192

feat(react api): added autogenerated express project

0f3fb39

Related OWASP#192

chore(react api): upgraded dependencies

f7aebe7

- Related OWASP#192 ``` cookie-parser ~1.4.4 → ~1.4.5 debug ~2.6.9 → ~4.1.1 express ~4.16.1 → ~4.17.1 http-errors ~1.6.3 → ~1.7.3 morgan ~1.9.1 → ~1.10.0 ```

feat(react api): added config files

8b1884d

- Related OWASP#192 - Added depedency `[email protected]` - Added main config file

chore(files): updated gitignore rules

5034336

See: https://www.gitignore.io/api/node,code,linux,macos,windows,webstorm,sublimetext

fix(react api): project name

9ba3401

Related OWASP#192

refactor(react api): ES6 migration

0efe7f0

Related OWASP#192

refactor(react api): ES6 migration

49493d9

Related OWASP#192

feat(react api): added standard linter

67cefa0

- Related OWASP#192 - Added dev dependency `[email protected]` - Added npm tasks for linting

feat(react api): added lint git hook

d316b82

Related OWASP#192

chore(react api): files linted

bcaf6ef

feat(react api): added test environment

414e602

- Related OWASP#192 - Added dev dependencies `[email protected]` & `[email protected]` - Added npm tasks for testing

feat(react api): added test git hook

83e6b58

Related OWASP#192

chore(react api): update linting rules

00bc5f3

feat(react api): added initial tests

e591970

Related OWASP#192

chore(react client): upgrade testing dependencies

fed2529

- Updated testing dependencies ``` @testing-library/jest-dom ^4.2.4 → ^5.1.1 @testing-library/react ^9.3.2 → ^10.0.1 @testing-library/user-event ^7.1.2 → ^10.0.0 ```

feat(react client): added linter to project

a24718b

- Related OWASP#192

feat(react client): added npm tasks for linting

b77296b

- Related OWASP#192

chore(react client): files linted

780c963

- Added jest to eslint rules - Linted files

WIP(react client): npm tasks for testing

fc07d62

- Related OWASP#192 - Added watch and CI support - Missing coverage and snapshot update

feat(react client): added styled component & material UI

2f07bf1

Related OWASP#192

feat(react client): added material ui icons

25addff

Related OWASP#192

feat(react client): updated app component

5731cd9

Related OWASP#192

sher04lock mentioned this pull request Apr 22, 2020

#183 Map OWASP API Top 10 to NodeGoat functionalities. #194

Open

UlisesGascon mentioned this pull request May 30, 2020

Feature: Lerna #189

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/192 #193

Feature/192 #193

KoolTheba commented Mar 22, 2020

lirantal commented Mar 6, 2023

KoolTheba commented Mar 6, 2023

lirantal commented Mar 6, 2023

KoolTheba commented Mar 19, 2023

lirantal commented Apr 2, 2023

lirantal commented Jul 17, 2023

KoolTheba commented Aug 4, 2023

lirantal commented Aug 4, 2023

KoolTheba commented Aug 13, 2023

Feature/192 #193

Are you sure you want to change the base?

Feature/192 #193

Conversation

KoolTheba commented Mar 22, 2020

⚠️ WIP please no merge!

IMPORTANT

PR Backlog (see #192)

Notable changes

React api

React client

Changelog

lirantal commented Mar 6, 2023

KoolTheba commented Mar 6, 2023

lirantal commented Mar 6, 2023

KoolTheba commented Mar 19, 2023

lirantal commented Apr 2, 2023

lirantal commented Jul 17, 2023

KoolTheba commented Aug 4, 2023

lirantal commented Aug 4, 2023

KoolTheba commented Aug 13, 2023