Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mysql connections #1001

Closed
wants to merge 1 commit into from
Closed

fixed mysql connections #1001

wants to merge 1 commit into from

Conversation

pUrGe12
Copy link
Contributor

@pUrGe12 pUrGe12 commented Feb 5, 2025

Proposed change

Addressing issues mentioned #999 and #555. The database configurations were addressing only SQLite, I have changed that to include MySQL as well. It works well locally.

Type of change

  • New core framework functionality
  • Bugfix (non-breaking change which fixes an issue)
  • Code refactoring without any functionality changes
  • New or existing module/payload change
  • Localization improvement
  • Dependency upgrade
  • Documentation improvement

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@pUrGe12
Copy link
Contributor Author

pUrGe12 commented Feb 5, 2025

I didn't read your earlier comment @securestep9 on the previous PR. I will close this.

@pUrGe12 pUrGe12 closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant