Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of Threat Model Cheatshet #1227

Merged
merged 6 commits into from
Nov 22, 2023
Merged

Update of Threat Model Cheatshet #1227

merged 6 commits into from
Nov 22, 2023

Conversation

EbonyAdder
Copy link
Contributor

@EbonyAdder EbonyAdder commented Nov 16, 2023

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #1221

Thank you again for your contribution 😃

Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is amazing work. So easy to read and concise.
I left a few proofreading suggestions but in terms of content I think it's perfect!

cheatsheets/Threat_Modeling_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Threat_Modeling_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Threat_Modeling_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Threat_Modeling_Cheat_Sheet.md Outdated Show resolved Hide resolved
@szh szh self-assigned this Nov 17, 2023
@szh szh linked an issue Nov 17, 2023 that may be closed by this pull request
@EbonyAdder
Copy link
Contributor Author

Thanks much for the kind words and suggestions. I have incorporated them. Apologies for the multiple commits stemming from the suggestions - I thought it was going to combine them (don't have a ton of experience with Github.com). I can squash them if needed.

@szh
Copy link
Collaborator

szh commented Nov 21, 2023

This looks great. I noticed the PR is still marked as a draft - do you want me to mark it as ready for review so we can merge it? Or are you still planning to make more changes?

@EbonyAdder EbonyAdder marked this pull request as ready for review November 21, 2023 22:56
@EbonyAdder
Copy link
Contributor Author

Thanks, yes, am done making edits so I have flagged as ready for review. Again, much appreciate the feedback.

Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szh szh merged commit 5a9b08f into OWASP:master Nov 22, 2023
3 checks passed
@izar
Copy link
Contributor

izar commented Apr 15, 2024

Hello - this update removed a lot of information, for example, OWASP pytm from the list of tools. Before I go and add it again, I wanted to ask if there was any specific reason for the removal.

@jmanico
Copy link
Member

jmanico commented Apr 15, 2024

A lot of the information removed was from older projects. If you add any project back in, can you please check first if the project is still active? Thank you!

@izar
Copy link
Contributor

izar commented Apr 15, 2024

It most certainly is active. I'll add it again, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update: Threat Modeling
4 participants