-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of Threat Model Cheatshet #1227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is amazing work. So easy to read and concise.
I left a few proofreading suggestions but in terms of content I think it's perfect!
Co-authored-by: Shlomo Zalman Heigh <[email protected]>
Co-authored-by: Shlomo Zalman Heigh <[email protected]>
Co-authored-by: Shlomo Zalman Heigh <[email protected]>
Co-authored-by: Shlomo Zalman Heigh <[email protected]>
Thanks much for the kind words and suggestions. I have incorporated them. Apologies for the multiple commits stemming from the suggestions - I thought it was going to combine them (don't have a ton of experience with Github.com). I can squash them if needed. |
This looks great. I noticed the PR is still marked as a draft - do you want me to mark it as ready for review so we can merge it? Or are you still planning to make more changes? |
Thanks, yes, am done making edits so I have flagged as ready for review. Again, much appreciate the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello - this update removed a lot of information, for example, OWASP pytm from the list of tools. Before I go and add it again, I wanted to ask if there was any specific reason for the removal. |
A lot of the information removed was from older projects. If you add any project back in, can you please check first if the project is still active? Thank you! |
It most certainly is active. I'll add it again, thanks. |
Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.
Please make sure that for your contribution:
If your PR is related to an issue, please finish your PR text with the following line:
This PR covers issue #1221
Thank you again for your contribution 😃