-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no redirect to HTTPS to resolve #2416 #2432
Conversation
I think the wording still needs some improvements, an attempt:
Probably it is level 2 requirement (not level 1) |
Your wording leads to a negative requirement. I agree with the level comment and I also clarified the second part of the req. I would propose:
|
But I would still say level 2. It's easy to implement. |
Fair comment @elarlang, I updated the PR so are you comfortable to approve now? |
I know this is merged but this text is a little awkward.
This is redundant.
This alone can be problematic. The better call it to not respond at all: So I suggest we just keep this simple, with text like. Verify that HTTPS-based endpoints do not respond to HTTP requests. This drops the negative requirement of not redirecting, drops the "error message" part, and simplifies the language. |
You can re-open related issue (#2416) with recommendations. |
This Pull Request relates to issue #2416