-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(French Translation): French Translation for the 2023 edition #130
(French Translation): French Translation for the 2023 edition #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass on my review for this french translation.
editions/2023/fr/0xa6-unrestricted-access-to-sensitive-business-flows.md
Outdated
Show resolved
Hide resolved
editions/2023/fr/0xa6-unrestricted-access-to-sensitive-business-flows.md
Show resolved
Hide resolved
editions/2023/fr/0xa6-unrestricted-access-to-sensitive-business-flows.md
Show resolved
Hide resolved
I will try to finish my review as soon as possible. @Nounoursdestavernes Good work btw and thank you for your contribution. |
Thx for the review @llegaz I made the modifications :) It's my first contribution to an Open Source project and first translation it was not as easy as I thought so I thank you a lot for your help ;) I will be happy to continue to improve the quality of the translation if you have any changes to suggest |
Hi everyone, Do you have any update about my last commentaries @llegaz ? I was wondering if you had the time to consider them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've finished to review this translation for the 2023 edition.
Except for the few suggestions everything is good to go on my side :)
Hi @Nounoursdestavernes I'll need a few days to work on this to make sure everything works as expected after merging. |
Correction of some translation mistake Co-authored-by: Laurent Legaz <[email protected]>
Co-authored-by: Laurent Legaz <[email protected]>
Co-authored-by: Laurent Legaz <[email protected]>
Co-authored-by: Laurent Legaz <[email protected]>
Co-authored-by: Laurent Legaz <[email protected]>
Co-authored-by: Laurent Legaz <[email protected]>
Co-authored-by: Laurent Legaz <[email protected]>
Co-authored-by: Laurent Legaz <[email protected]>
Co-authored-by: Laurent Legaz <[email protected]>
Hi @PauloASilva Thanks a lot @llegaz for your review :) |
…ecurity into translation/fr
You are very welcome @Nounoursdestavernes thanks again for your work. |
Hi there, Is everything okay ? Should I make any changes to the PR ? @PauloASilva Best regards, |
I didn't find the time yet to review the PR (make sure everything works properly). |
Hello there,
This is my PR for the french translation. (#129)
Let me know if you want any changes.
Best regards,
NounoursDesTavernes / Aurélien TRONCY.