-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
なろうServiceのリファクタリング #24
Conversation
c3ef9a1
to
f9d85b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
どこかのタイミングでMainViewModel.csの157行目を "https://ncode.syosetu.com" に変更しておいてほしいです
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
document.Chapters.Add()
を行う時には、 chapterTitle
の更新が必要です。
ReadPageAsync()
内で、chapterTitle
を取得する際の連載の場合と短編の場合との処理が逆です。
Co-authored-by: TaPet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.