feat: add support for extra volume mounts for redis sentinel #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsoica
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #994 +/- ##
==========================================
+ Coverage 35.20% 44.78% +9.58%
==========================================
Files 19 20 +1
Lines 3213 2686 -527
==========================================
+ Hits 1131 1203 +72
+ Misses 2015 1413 -602
- Partials 67 70 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: laurentiusoica <[email protected]>
lsoica
changed the title
Signed-off-by: laurentiusoica <[email protected]>
Signed-off-by: laurentiusoica <[email protected]>
Signed-off-by: laurentiusoica <[email protected]>
|
@drivebyer could I have your review here please? |
@lsoica Sure, I will review this within today. |
drivebyer
approved these changes
Jun 19, 2024
mattrobinsonsre
pushed a commit
to mattrobinsonsre/redis-operator
that referenced
this pull request
Jul 11, 2024
…AINER-KIT#994) * feat: add support for extra volume mounts for redis sentinel Signed-off-by: laurentiusoica <[email protected]> * fix: add tests Signed-off-by: laurentiusoica <[email protected]> * fix: yaml lint Signed-off-by: laurentiusoica <[email protected]> * fix: docs Signed-off-by: laurentiusoica <[email protected]> --------- Signed-off-by: laurentiusoica <[email protected]> Co-authored-by: laurentiusoica <[email protected]> Signed-off-by: Matt Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the capability to mount extra volumes for the Redis Sentinel STS. One use case is the sentinel config file which is dynamically created at boot time so it needs write access to a file system.
Fixes #970
Type of change
Checklist