Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ReadyReplicas need to be checked in IsStatefulSetReady #993

Merged
merged 1 commit into from
Jun 16, 2024
Merged

fix: ReadyReplicas need to be checked in IsStatefulSetReady #993

merged 1 commit into from
Jun 16, 2024

Conversation

drivebyer
Copy link
Collaborator

No description provided.

@drivebyer drivebyer added the bug Something isn't working label Jun 16, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 44.66%. Comparing base (d121d86) to head (04783e0).
Report is 74 commits behind head on master.

❗ Current head 04783e0 differs from pull request most recent head 31c1bd8

Please upload reports for the commit 31c1bd8 to get more accurate results.

Files Patch % Lines
k8sutils/statefulset.go 0.00% 3 Missing ⚠️
controllers/rediscluster_controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
+ Coverage   35.20%   44.66%   +9.46%     
==========================================
  Files          19       20       +1     
  Lines        3213     2680     -533     
==========================================
+ Hits         1131     1197      +66     
+ Misses       2015     1413     -602     
- Partials       67       70       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit 2838af4 into OT-CONTAINER-KIT:master Jun 16, 2024
52 of 53 checks passed
@drivebyer drivebyer deleted the fix-cluster-creation branch June 16, 2024 15:30
lsoica pushed a commit to lsoica/redis-operator that referenced this pull request Jun 17, 2024
@drivebyer @laurentiusoica
fix: ReadyReplicas need to be checked in IsStatefulSetReady (OT-CON…
c7d266d 
…TAINER-KIT#993)

Signed-off-by: drivebyer <[email protected]>
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
@drivebyer @mattrobinsonsre
fix: ReadyReplicas need to be checked in IsStatefulSetReady (OT-CON…
2a77650 
…TAINER-KIT#993)

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamabhishek-dubey iamabhishek-dubey Awaiting requested review from iamabhishek-dubey iamabhishek-dubey is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drivebyer