Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Cover Createorupdatestateful #968

Merged
merged 9 commits into from
Jun 19, 2024
Merged

test: Cover Createorupdatestateful #968

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
216ebcb
test:CreateOrUpdateStateFul test case
k3mahesh May 30, 2024
48d5869
createorupdatestateful-test cover
k3mahesh Jun 4, 2024
3540d30
test:createorupdatestateful fixing liniting
k3mahesh Jun 5, 2024
a33af6f
fixing linting
k3mahesh Jun 5, 2024
56bf204
test: createorupdatestateful cover
k3mahesh Jun 6, 2024
9ecbdcc
test: fixing linting
k3mahesh Jun 6, 2024
051f571
Merge branch 'OT-CONTAINER-KIT:master' into createorupdatestateful-test
k3mahesh Jun 12, 2024
7ec1547
test: fixed liniting
Jun 14, 2024
bcda9ae
test: added new test case with error
k3mahesh Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 173 additions & 0 deletions k8sutils/statefulset_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,179 @@ func TestUpdateStatefulSet(t *testing.T) {
}
}

func TestCreateOrUpdateStateFul(t *testing.T) {
logger := logr.Discard()
tests := []struct {
name string
stsParams statefulSetParameters
stsOwnerDef metav1.OwnerReference
initContainerParams initContainerParameters
containerParams containerParameters
sidecar *[]redisv1beta2.Sidecar
existingStatefulSet appsv1.StatefulSetSpec
updatedStatefulSet appsv1.StatefulSetSpec
stsPresent bool
expectErr error
}{
{
name: "Test1_Create_Statefulset",
stsParams: statefulSetParameters{
Replicas: ptr.To(int32(4)),
},
stsOwnerDef: metav1.OwnerReference{
Name: "test-sts",
},
initContainerParams: initContainerParameters{
Image: "redis-init:latest",
},
containerParams: containerParameters{
Image: "redis:latest",
ReadinessProbe: &corev1.Probe{
InitialDelaySeconds: int32(5),
},
LivenessProbe: &corev1.Probe{
InitialDelaySeconds: int32(5),
},
},
sidecar: &[]redisv1beta2.Sidecar{
{
Sidecar: common.Sidecar{
Name: "redis-sidecare",
},
Command: []string{"/bin/bash", "-c", "/app/restore.bash"},
},
},
existingStatefulSet: appsv1.StatefulSetSpec{
Replicas: ptr.To(int32(4)),
},
stsPresent: false,
},
{
name: "Test2_udpate_Statefulset",
stsParams: statefulSetParameters{
Replicas: ptr.To(int32(4)),
},
stsOwnerDef: metav1.OwnerReference{
Name: "test-sts",
},
initContainerParams: initContainerParameters{
Image: "redis-init:latest",
},
containerParams: containerParameters{
Image: "redis:latest",
ReadinessProbe: &corev1.Probe{
InitialDelaySeconds: int32(5),
},
LivenessProbe: &corev1.Probe{
InitialDelaySeconds: int32(5),
},
},
sidecar: &[]redisv1beta2.Sidecar{
{
Sidecar: common.Sidecar{
Name: "redis-sidecare",
},
Command: []string{"/bin/bash", "-c", "/app/restore.bash"},
},
},
existingStatefulSet: appsv1.StatefulSetSpec{
Replicas: ptr.To(int32(4)),
},
updatedStatefulSet: appsv1.StatefulSetSpec{
Replicas: ptr.To(int32(6)),
},
stsPresent: true,
},
{
name: "Test3_Create_Statefulset_With_Error",
stsParams: statefulSetParameters{
Replicas: ptr.To(int32(4)),
},
stsOwnerDef: metav1.OwnerReference{
Name: "test-sts",
},
initContainerParams: initContainerParameters{
Image: "redis-init:latest",
},
containerParams: containerParameters{
Image: "redis:latest",
ReadinessProbe: &corev1.Probe{
InitialDelaySeconds: int32(5),
},
LivenessProbe: &corev1.Probe{
InitialDelaySeconds: int32(5),
},
},
sidecar: &[]redisv1beta2.Sidecar{},
existingStatefulSet: appsv1.StatefulSetSpec{
Replicas: ptr.To(int32(4)),
},
updatedStatefulSet: appsv1.StatefulSetSpec{
Replicas: ptr.To(int32(-6)),
},
stsPresent: false,
expectErr: kerrors.NewBadRequest("Invalid Value of Replicas"),
},
}

assert := assert.New(t)

for i := range tests {
test := tests[i]
t.Run(test.name, func(t *testing.T) {
var client *k8sClientFake.Clientset

if test.stsPresent {
existingSts := appsv1.StatefulSet{
ObjectMeta: metav1.ObjectMeta{
Name: "test-sts",
Namespace: "test-ns",
},
Spec: *test.existingStatefulSet.DeepCopy(),
}

updatedSts := appsv1.StatefulSet{
ObjectMeta: metav1.ObjectMeta{
Name: "test-sts",
Namespace: "test-ns",
},
Spec: *test.updatedStatefulSet.DeepCopy(),
}
if test.stsPresent {
client = k8sClientFake.NewSimpleClientset(existingSts.DeepCopy())
} else {
client = k8sClientFake.NewSimpleClientset()
}
err := CreateOrUpdateStateFul(client, logger, updatedSts.GetNamespace(), updatedSts.ObjectMeta, test.stsParams, test.stsOwnerDef, test.initContainerParams, test.containerParams, test.sidecar)
if test.expectErr != nil {
assert.Error(err, "Expected Error while updating Statefulset")
assert.Equal(test.expectErr, err)
} else {
assert.NoError(err, "Error while updating Statefulset")
}
if err == nil {
getUpdatedSts, err := client.AppsV1().StatefulSets(updatedSts.GetNamespace()).Get(context.TODO(), updatedSts.GetName(), metav1.GetOptions{})
assert.NoError(err)
assert.NotEqual(getUpdatedSts.DeepCopy(), existingSts.DeepCopy(), "StatefulSet Updated")
}
} else {
updatedSts := appsv1.StatefulSet{
ObjectMeta: metav1.ObjectMeta{
Name: "test-sts",
Namespace: "",
},
Spec: *test.updatedStatefulSet.DeepCopy(),
}

client = k8sClientFake.NewSimpleClientset()

err := CreateOrUpdateStateFul(client, logger, updatedSts.GetNamespace(), updatedSts.ObjectMeta, test.stsParams, test.stsOwnerDef, test.initContainerParams, test.containerParams, test.sidecar)
assert.Nil(err)
}
})
}
}

func TestEnableRedisMonitoring(t *testing.T) {
tests := []struct {
name string
Expand Down
Loading