Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless comments #761

Merged

Conversation

MathieuCesbron
Copy link
Contributor

Description

Remove useless comments on all reconcile functions.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: Mathieu Cesbron <[email protected]>
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e6fcb9) 32.79% compared to head (ebd40bb) 32.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
- Coverage   32.79%   32.77%   -0.03%     
==========================================
  Files          19       19              
  Lines        3232     3231       -1     
==========================================
- Hits         1060     1059       -1     
  Misses       2113     2113              
  Partials       59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamabhishek-dubey iamabhishek-dubey marked this pull request as ready for review March 27, 2024 10:33
@shubham-cmyk shubham-cmyk merged commit bf1a5a9 into OT-CONTAINER-KIT:master Mar 29, 2024
29 checks passed
wkd-woo pushed a commit to wkd-woo/redis-operator that referenced this pull request Apr 1, 2024
Signed-off-by: Mathieu Cesbron <[email protected]>
Signed-off-by: wkd-woo <[email protected]>
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
Signed-off-by: Mathieu Cesbron <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants