Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused client in reconciler #756

Conversation

MathieuCesbron
Copy link
Contributor

Description

Remove unused clients, we only use k8sclient and dk8sClient.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Signed-off-by: Mathieu Cesbron <[email protected]>
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e1ba97) 32.79% compared to head (509b619) 32.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
- Coverage   32.79%   32.70%   -0.10%     
==========================================
  Files          19       19              
  Lines        3232     3232              
==========================================
- Hits         1060     1057       -3     
- Misses       2113     2115       +2     
- Partials       59       60       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant