Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate dynamic k8s client only once #752

Conversation

MathieuCesbron
Copy link
Contributor

Description

We generated a new dynamic k8s client everytime we needed it. Now we use the one that is generated in main.go only.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (169194a) 29.89% compared to head (1875c92) 30.11%.

Files Patch % Lines
controllers/rediscluster_controller.go 0.00% 5 Missing ⚠️
k8sutils/redis-sentinel.go 60.00% 4 Missing ⚠️
k8sutils/status.go 0.00% 2 Missing ⚠️
controllers/redissentinel_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
+ Coverage   29.89%   30.11%   +0.21%     
==========================================
  Files          19       19              
  Lines        3241     3231      -10     
==========================================
+ Hits          969      973       +4     
+ Misses       2233     2218      -15     
- Partials       39       40       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MathieuCesbron MathieuCesbron force-pushed the generate_dynamic_k8s_client_only_once branch from 65fa47a to 1875c92 Compare January 17, 2024 19:55
@MathieuCesbron MathieuCesbron marked this pull request as ready for review January 17, 2024 20:06
@drivebyer drivebyer self-requested a review January 18, 2024 02:17
@drivebyer drivebyer enabled auto-merge (squash) January 18, 2024 02:17
@drivebyer drivebyer merged commit 629c2df into OT-CONTAINER-KIT:master Jan 18, 2024
29 checks passed
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants