Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add namespace creation #746

Merged

Conversation

MathieuCesbron
Copy link
Contributor

Description

If we follow the installation guidelines, it failed because the namespace ot-operators does not exist. We add a line to create it in the documentation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef99c4d) 28.80% compared to head (669d3f6) 28.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   28.80%   28.80%           
=======================================
  Files          19       19           
  Lines        3291     3291           
=======================================
  Hits          948      948           
  Misses       2308     2308           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mathieu Cesbron <[email protected]>
@drivebyer
Copy link
Collaborator

drivebyer commented Jan 11, 2024

Thanks for your contribution. :)

How about use helm upgrade --install XXX --create-namespace -n ot-operators? It can combine namespace creation and helm install to one command.

@drivebyer drivebyer changed the title Add namespace creation in doc docs: add namespace creation Jan 11, 2024
Signed-off-by: Mathieu Cesbron <[email protected]>
@MathieuCesbron
Copy link
Contributor Author

Thanks for the suggestion, it is indeed better this way ! I just updated the commit, it should be good.

I added the namespace creation every time we helm upgrade the operator.

@drivebyer drivebyer enabled auto-merge (squash) January 11, 2024 08:34
@drivebyer drivebyer self-requested a review January 11, 2024 08:34
Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drivebyer drivebyer merged commit e57531a into OT-CONTAINER-KIT:master Jan 11, 2024
17 of 29 checks passed
@MathieuCesbron MathieuCesbron deleted the Add_namespace_creation_in_doc branch January 11, 2024 08:39
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
* Remove trailing whitespaces

Signed-off-by: Mathieu Cesbron <[email protected]>

* Add namespace creation on doc

Signed-off-by: Mathieu Cesbron <[email protected]>

---------

Signed-off-by: Mathieu Cesbron <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants