-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sentinel cluster size validation no effect #536
Conversation
PTAL @shubham-cmyk |
I won't like to enforce an odd number of sentinels on users however having exactly 2 sentinels ( which is already taken care of ) could have conflict while making decisions but having a higher number of sentinels like 4,6,8 would be fine. What do you think about that |
(For a cluster of n nodes, the quorum is n/2 + 1.) Reference : https://martinfowler.com/articles/quorum.html |
hi @shubham-cmyk, according to https://redis.io/docs/management/sentinel/, the docs says:
So I think, the If clustersize is 5, the majority is 3, we can tolerate 2 sentinel failed. If If clustersize is 6, the majority is 2, we can tolerate 2 sentinel failed too. That's less efficiency. |
I think we could remove |
Yes! We could use odd number but after 5 sentinel nodes there are very less chance of concurrent failure. so I think there would be hardly any improvement the main issue is with exactly 2 which posses most risk of failure. |
But I am writing a validation webhook for the same where we could take care of this so right now. |
Yes of course |
Signed-off-by: drivebyer <[email protected]>
) Signed-off-by: drivebyer <[email protected]> Signed-off-by: guozhi.li <[email protected]>
Description
There is not
Not
validation in kubebuilder. We can useEnum
to limit sentinel size to some odd number. https://book.kubebuilder.io/reference/markers/crd-validation.htmlType of change
Checklist