Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:Resize pvc for RedisCluster #463

Closed
wants to merge 36 commits into from
Closed

fix:Resize pvc for RedisCluster #463

wants to merge 36 commits into from

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Mar 21, 2023 •
edited
Loading

Resize pvc for RedisCluster

Description

  1. pvc for RedisCluster have labels：
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: xxxx
  labels:
    app: test-redis-c-leader
    app.kubernetes.io/component: redis
    app.kubernetes.io/name: test-redis-c
    redis_setup_type: cluster
    role: leader

Here app is sts's Name,app. kubernetes.io/name is CR's name,so we match label just app and redis

Fixes #ISSUE

Type of change

Bug fix

  • Bug fix

Checklist

  • Testing has been performed
  • No functionality is broken
  • Documentation updated

@iamabhishek-dubey
Copy link
Member

@jiuker, this will not enable the resizing of persistent volume; labels will not impact resizing. It needs to be triggered manually as of now.

But as the label is missing, this PR can be merged. Please fix the linters.

@jiuker
Copy link
Contributor Author

jiuker commented Apr 9, 2023

Member

** iamabhishek-dubey**

@iamabhishek-dubey I didn't find this needed to fix the linter? Looks like a cicd environment problem?

jiuker and others added 28 commits July 20, 2023 15:13
@jiuker
fix:Resize pvc for RedisCluster
73330d6 
Resize pvc for RedisCluster

Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
Revert "Fixed StatefulSet(sentinel) Label for Service(Selector) OT-CO…
31dc005 
…NTAINER-KIT#434 OT-CONTAINER-KIT#435"

This reverts commit 61f0829.

Signed-off-by: guozhi.li <[email protected]>
@artificial-aidan
declare module correctly
0390f72 
Signed-off-by: Aidan Jensen <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
Declare Module Correctly : Sentinel
894b1f2 
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
Lint (OT-CONTAINER-KIT#479)
b0b0d4d 
* add : Lint

Signed-off-by: Shubham Gupta <[email protected]>

* fix : Lint

Signed-off-by: Shubham Gupta <[email protected]>

* Add : Linter Setting

Signed-off-by: Shubham Gupta <[email protected]>

* fix : lint

Signed-off-by: Shubham Gupta <[email protected]>

* Fix : Lint

Signed-off-by: Shubham Gupta <[email protected]>

* add : ALL

Signed-off-by: Shubham Gupta <[email protected]>

* Fix : Lint

Signed-off-by: Shubham Gupta <[email protected]>

* Comment : Lint

Signed-off-by: Shubham Gupta <[email protected]>

* Disable : go mod directive

Signed-off-by: Shubham Gupta <[email protected]>

* Remove deadline

Signed-off-by: Shubham Gupta <[email protected]>

* update : Lint Check

Signed-off-by: Shubham Gupta <[email protected]>

* ignore : Json tag

Signed-off-by: Shubham Gupta <[email protected]>

* Update : TagLiatelle

Signed-off-by: Shubham Gupta <[email protected]>

* remove go version for a while

Signed-off-by: Shubham Gupta <[email protected]>

* Fix : lint

Signed-off-by: Shubham Gupta <[email protected]>

* skip files

Signed-off-by: Shubham Gupta <[email protected]>

* fix : lint

Signed-off-by: Shubham Gupta <[email protected]>

* skip dir

Signed-off-by: Shubham Gupta <[email protected]>

* fix : config

Signed-off-by: Shubham Gupta <[email protected]>

* skip dir

Signed-off-by: Shubham Gupta <[email protected]>

* skip di 2

Signed-off-by: Shubham Gupta <[email protected]>

* skip dir

Signed-off-by: Shubham Gupta <[email protected]>

* skip file

Signed-off-by: Shubham Gupta <[email protected]>

* skip file

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk @sadath-12
Updated README.md to add delete commands (OT-CONTAINER-KIT#466)
3f097f8 
* Update README.md

* Update README.md

Signed-off-by: sadath-12 [email protected]

* fix : PR

Signed-off-by: Shubham Gupta <[email protected]>

* fix : MD034

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: sadath-12 [email protected]
Signed-off-by: Shubham Gupta <[email protected]>
Co-authored-by: syedsadath-17 <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
Documentation [ Redis Replication and Redis Sentinel ] (OT-CONTAINER-…
ff998c8 
…KIT#465)

* add : overview

Signed-off-by: Shubham Gupta <[email protected]>

* fix : installation

Signed-off-by: Shubham Gupta <[email protected]>

* Add : Documentation replication and sentinel mode

Signed-off-by: Shubham Gupta <[email protected]>

* add Images

Signed-off-by: Shubham Gupta <[email protected]>

* Add : Docs Sentinel

Signed-off-by: Shubham Gupta <[email protected]>

* update Image

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@muicoder
[Feature]: Add RedisExporter for sentinel OT-CONTAINER-KIT#441 (OT-CO…
d869ff4 
…NTAINER-KIT#440)

Signed-off-by: muicoder <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@sadath-12
Add : CRD for the Redis-Sentinel ( Exporter ) and Update : Kustomize (O…
d1c3758 
…T-CONTAINER-KIT#482)

* BUG-FIX:ADDED-CRD-MANIFESTS-PATH

Signed-off-by: sadath-12 <[email protected]>

* UNDO MAKEFILE CHANGES

Signed-off-by: sadath-12 <[email protected]>

---------

Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@dependabot
Bump golang.org/x/crypto from 0.0.0-20210817164053-32db794688a5 to 0.…
f43e584 
…1.0 (OT-CONTAINER-KIT#456)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20210817164053-32db794688a5 to 0.1.0.
- [Release notes](https://github.com/golang/crypto/releases)
- [Commits](https://github.com/golang/crypto/commits/v0.1.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: guozhi.li <[email protected]>
@sadath-12
fix: exporter ports enabled even when exporters disabled (OT-CONTAINE…
abce2b1 
…R-KIT#484)

* fix: exporter ports enabled even when exporters disabled

Signed-off-by: sadath-12 <[email protected]>

* fix: dependency issues

Signed-off-by: sadath-12 <[email protected]>

---------

Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@drivebyer @shubham-cmyk
[Feature]: Add InitContainer Field (OT-CONTAINER-KIT#458)
0b143b6 
* Add init container fields

Signed-off-by: drivebyer <[email protected]>

* define : init Container

Signed-off-by: Shubham Gupta <[email protected]>

* update : name of Init Container

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Co-authored-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@Sasidharan3094 @Sasidharan-Gopal
Adding few more features for Sidecar and custom TerminationGracePerio…
1e49e11 
…dSeconds (OT-CONTAINER-KIT#487)

* initial commit

Signed-off-by: Sasidharan-3094 <[email protected]>

* updating

Signed-off-by: Sasidharan-3094 <[email protected]>

* + Sidecar features & termgraceperiodsecs

Signed-off-by: Sasidharan-3094 <[email protected]>

* generating manager

Signed-off-by: Sasidharan-3094 <[email protected]>

* PR Comments

Signed-off-by: Sasidharan-3094 <[email protected]>

---------

Signed-off-by: Sasidharan-3094 <[email protected]>
Co-authored-by: Sasidharan Gopal <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
Feature : ACL redis via secret (OT-CONTAINER-KIT#486)
9e3dfe3 
* Feature : acl-redis via configmap

Signed-off-by: Shubham Gupta <[email protected]>

* update : acl volume source from config to secret

Signed-off-by: Shubham Gupta <[email protected]>

* update : examples

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
Revert "Adding few more features for Sidecar and custom TerminationGr…
0d7b4f5 
…acePeriodSeconds (OT-CONTAINER-KIT#487)" (OT-CONTAINER-KIT#492)

This reverts commit 559f40a.

Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
back up and restore (OT-CONTAINER-KIT#489)
36cf66d 
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
upgrade version (OT-CONTAINER-KIT#496)
11a65b9 
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@Sasidharan3094 @drivebyer
@shubham-cmyk @Sasidharan-Gopal
Bugfix on the TerminationGracePeriodSeconds change (OT-CONTAINER-KIT#493
dbf8ff2 
)

* [Feature]: Add InitContainer Field (OT-CONTAINER-KIT#458)

* Add init container fields

Signed-off-by: drivebyer <[email protected]>

* define : init Container

Signed-off-by: Shubham Gupta <[email protected]>

* update : name of Init Container

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Co-authored-by: Shubham Gupta <[email protected]>
Signed-off-by: Sasidharan-3094 <[email protected]>

* initial commit

Signed-off-by: Sasidharan-3094 <[email protected]>

* updating

Signed-off-by: Sasidharan-3094 <[email protected]>

* + Sidecar features & termgraceperiodsecs

Signed-off-by: Sasidharan-3094 <[email protected]>

* generating manager

Signed-off-by: Sasidharan-3094 <[email protected]>

* PR Comments

Signed-off-by: Sasidharan-3094 <[email protected]>

* Feature : ACL redis via secret (OT-CONTAINER-KIT#486)

* Feature : acl-redis via configmap

Signed-off-by: Shubham Gupta <[email protected]>

* update : acl volume source from config to secret

Signed-off-by: Shubham Gupta <[email protected]>

* update : examples

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Sasidharan-3094 <[email protected]>

* bugFix

Signed-off-by: Sasidharan-3094 <[email protected]>

* fix

---------

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Sasidharan-3094 <[email protected]>
Co-authored-by: drivebyer <[email protected]>
Co-authored-by: Shubham Gupta <[email protected]>
Co-authored-by: Sasidharan Gopal <[email protected]>
Co-authored-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@tokamoto-idcf
Fix: Corrected scenario "go-install-tool" in makefile (OT-CONTAINER-K…
6fec8e2 
…IT#499)

Signed-off-by: Taisuke Okamoto <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@chobostar
Revert "Optimize pvcTemplate Name for Storage OT-CONTAINER-KIT#438 (O…
6b3930c 
…T-CONTAINER-KIT#445)" (OT-CONTAINER-KIT#510)

This reverts commit ff6980f.

Signed-off-by: chobostar <[email protected]>
Co-authored-by: Kirill Petrov <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
Manage (Pod and Container) security Context (OT-CONTAINER-KIT#518)
2fdd2e8 
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
Fix Bug : Operator Crash when persistence is false (OT-CONTAINER-KIT#519
10453b0 
)

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@progmatv @shubham-cmyk
add watchnamespace function (OT-CONTAINER-KIT#520)
7d4100c 
* add watchnamespace function

* change Env Variable Name

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Co-authored-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
fix the loop call of checkAttachedSlave (OT-CONTAINER-KIT#523)
cc4733e 
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@rlch @shubham-cmyk
fix: Only created /node-conf VolumeMount for clusters (OT-CONTAINER…
233e120 
…-KIT#532)

* fix: Only created /node-conf VolumeMount for clusters

Signed-off-by: RJM <[email protected]>

* change Variable Name

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: RJM <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Co-authored-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
Fix : Redis Sentinel Exporter ports in Env Vars (OT-CONTAINER-KIT#533)
1ff9833 
* Set up CI with Azure Pipelines

[skip ci]

* Update pipeline.yaml

* fix sentinel Exporter ports

Signed-off-by: Shubham Gupta <[email protected]>

* no change in azure pipeline

Signed-off-by: Shubham Gupta <[email protected]>

* update this pipeline

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@drivebyer
Fix sentinel default validation not effect (OT-CONTAINER-KIT#535)
becce05 
Signed-off-by: yang.wu <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@drivebyer
Remove validation which not support in kubebuilder (OT-CONTAINER-KIT#536
2ad63d8 
)

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
shubham-cmyk and others added 8 commits July 20, 2023 15:13
@shubham-cmyk @progmatv
Feature: Support Scaling for Redis Cluster (OT-CONTAINER-KIT#531)
1dcbc57 
* Set up CI with Azure Pipelines

[skip ci]

Signed-off-by: Shubham Gupta <[email protected]>

* Update pipeline.yaml

Signed-off-by: Shubham Gupta <[email protected]>

* Fix Bug : Operator Crash when persistence is false (OT-CONTAINER-KIT#519)

Signed-off-by: Shubham Gupta <[email protected]>

* add watchnamespace function (OT-CONTAINER-KIT#520)

* add watchnamespace function

* change Env Variable Name

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Co-authored-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>

* fix the loop call of checkAttachedSlave (OT-CONTAINER-KIT#523)

Signed-off-by: Shubham Gupta <[email protected]>

* Redis Cluster Scaling

Signed-off-by: Shubham Gupta <[email protected]>

* revert the pipeline

Signed-off-by: Shubham Gupta <[email protected]>

* comment some funcs

Signed-off-by: Shubham Gupta <[email protected]>

* remove Commented code

Signed-off-by: Shubham Gupta <[email protected]>

* Set up CI with Azure Pipelines

[skip ci]

* Update pipeline.yaml

* Revert "fix the loop call of checkAttachedSlave (OT-CONTAINER-KIT#523)"

This reverts commit 6713dbc.

* Revert "add watchnamespace function (OT-CONTAINER-KIT#520)"

This reverts commit e8bb2cd.

* Revert "Fix Bug : Operator Crash when persistence is false (OT-CONTAINER-KIT#519)"

This reverts commit faa45b5.

* Revert "Update pipeline.yaml"

This reverts commit db717f5.

* update pipeline

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Co-authored-by: progmatv <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
Bug Fix : Init Container tried to mount invalid volume name (OT-CONTA…
506f42e 
…INER-KIT#538)

* Set up CI with Azure Pipelines

[skip ci]

* Update pipeline.yaml

* revert azure pipeline

Signed-off-by: Shubham Gupta <[email protected]>

* update the pipeline

Signed-off-by: Shubham Gupta <[email protected]>

* bug fix invalid volume connect in Init Container

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
[Bugs] [ Refactor ] - Redis Cluster Scaling (OT-CONTAINER-KIT#539)
e0e0156 
* Set up CI with Azure Pipelines

[skip ci]

* Update pipeline.yaml

* revert azure pipeline

Signed-off-by: Shubham Gupta <[email protected]>

* update the pipeline

Signed-off-by: Shubham Gupta <[email protected]>

* follow up for the cluster scaling

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@muicoder
Fix finalizePVC name mismatch (OT-CONTAINER-KIT#541)
3170b06 
Signed-off-by: muicoder <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
[Fix] - Cluster leader failover loop if there is only a single leader (…
ee6407c 
…OT-CONTAINER-KIT#542)

* Cluster leader failover on a single replica

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@muicoder @shubham-cmyk
[Refactor] - Remove redundant finalizers from operator (OT-CONTAINER-…
9e8b2ba 
…KIT#540)

* Remove redundant finalizers

Signed-off-by: muicoder <[email protected]>

 because of CRs ownerReferences have already been associated

* Remove unwanted code

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Co-authored-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
Fix hard code of 1Mi (OT-CONTAINER-KIT#552)
682d2aa 
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@shubham-cmyk
Add Image Compatibilty Section of the Operator (OT-CONTAINER-KIT#556)
126bcb1 
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: guozhi.li <[email protected]>
@jiuker jiuker closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.