Corrects double negative of Storage Salvage Value in Objective Equation #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Sorry, not sure who I am supposed to flag as a reviewer! |
Member
Author
|
Hi @FraGard; just doing a check-in to see if your able to review this? Thanks in advance! |
There was a problem hiding this comment.
Pull Request Overview
Fixes the sign error in the storage salvage value term of the objective equation to correctly apply a single negative rather than a double negative.
- Removed the extra minus sign before
SalvageValueStorage - Ensured the salvage term is now subtracted exactly once in the cost sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106