Skip to content

Conversation

@mankoff
Copy link
Contributor

@mankoff mankoff commented Nov 10, 2025

Attempt to fix issues in #5985

@github-actions github-actions bot added raster Related to raster data processing C Related code is in C module labels Nov 10, 2025
@github-actions github-actions bot added Python Related code is in Python tests Related to Test Suite labels Nov 10, 2025
@metzm metzm changed the title r.latlong: return central pixel values for lat or long r.latlong: return central pixel values for lat or long Nov 11, 2025
Copy link
Contributor

@metzm metzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mankoff
Copy link
Contributor Author

mankoff commented Nov 11, 2025

Good to hear this is approved. I'm fairly new to GRASS development. Should I squash and force-push, update the commit comment, reference #3274, etc.? Anything else from me to do at this point?

@metzm
Copy link
Contributor

metzm commented Nov 15, 2025

Good to hear this is approved. I'm fairly new to GRASS development. Should I squash and force-push, update the commit comment, reference #3274, etc.? Anything else from me to do at this point?

Just press the friendly green "Squash and merge" button and delete your source branch mankoff:latlon. There is no need for any force-push and the commit comment is fine.

If you do not see a friendly green "Squash and merge" button below or if it is greyed out, you probably do not have rights to merge and someone else needs to merge.

@mankoff
Copy link
Contributor Author

mankoff commented Nov 15, 2025

I do not have that green button.

@metzm
Copy link
Contributor

metzm commented Nov 15, 2025

Then I will merge for you, but you need to delete your source branch yourself.

@metzm metzm merged commit e9e31a0 into OSGeo:main Nov 15, 2025
27 of 28 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C module Python Related code is in Python raster Related to raster data processing tests Related to Test Suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants