Skip to content

Conversation

@neteler
Copy link
Member

@neteler neteler commented Oct 10, 2025

Attempt to fix the following CI error (log) on releasebranch_8_4 by syncing to main:

 Running ./raster/r.texture/testsuite/test_texture.py...
========================================================================
...........F.
======================================================================
FAIL: test_sv (__main__.TestRasterreport.test_sv)
Testing method sv
----------------------------------------------------------------------
Traceback (most recent call last):
  File "raster/r.texture/testsuite/test_texture.py", line 144, in test_sv
    self.assertRasterFitsUnivar(output, reference=values, precision=1e-2)
  File "etc/python/grass/gunittest/case.py", line 289, in assertRasterFitsUnivar
    self.assertModuleKeyValue(
  File "etc/python/grass/gunittest/case.py", line 271, in assertModuleKeyValue
    self.fail(self._formatMessage(msg, stdMsg))
AssertionError: r.univar map=sv_SV percentile=90.0 nprocs=1 separator== -g difference:
mismatch values (key, reference, actual): [('max', 45368496, 45368492), ('mean', 2248724.38215788, 2248724.35922656), ('variance', 2332049495199.41, 2332049429651.92)]
command: r.univar map=sv_SV percentile=90.0 nprocs=1 separator== -g {'map': 'sv_SV', 'separator': '=', 'flags': 'g'}

----------------------------------------------------------------------
Ran 13 tests in 17.655s
FAILED (failures=1)

Looks like an ugly workaround here but in G85 (#5750) this part has been rewritten and backporting is too much work (for me).

Attempt to fix:

```sh
 Running ./raster/r.texture/testsuite/test_texture.py...
========================================================================
...........F.
======================================================================
FAIL: test_sv (__main__.TestRasterreport.test_sv)
Testing method sv
----------------------------------------------------------------------
Traceback (most recent call last):
  File "raster/r.texture/testsuite/test_texture.py", line 144, in test_sv
    self.assertRasterFitsUnivar(output, reference=values, precision=1e-2)
  File "etc/python/grass/gunittest/case.py", line 289, in assertRasterFitsUnivar
    self.assertModuleKeyValue(
  File "etc/python/grass/gunittest/case.py", line 271, in assertModuleKeyValue
    self.fail(self._formatMessage(msg, stdMsg))
AssertionError: r.univar map=sv_SV percentile=90.0 nprocs=1 separator== -g difference:
mismatch values (key, reference, actual): [('max', 45368496, 45368492), ('mean', 2248724.38215788, 2248724.35922656), ('variance', 2332049495199.41, 2332049429651.92)]
command: r.univar map=sv_SV percentile=90.0 nprocs=1 separator== -g {'map': 'sv_SV', 'separator': '=', 'flags': 'g'}

----------------------------------------------------------------------
Ran 13 tests in 17.655s
FAILED (failures=1)
```
@neteler neteler added this to the 8.4.2 milestone Oct 10, 2025
@neteler neteler self-assigned this Oct 10, 2025
@neteler neteler added macOS macOS specific CI Continuous integration labels Oct 10, 2025
@github-actions github-actions bot added raster Related to raster data processing Python Related code is in Python module tests Related to Test Suite labels Oct 10, 2025
@neteler neteler requested review from echoix and nilason October 10, 2025 09:56
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With your latest changes, it only adjusts the already inconsistent numbers, so I would say this is fine. You can link the actual fixes in the PR to make it clear that the ugliness is already resolved elsewhere.

@neteler
Copy link
Member Author

neteler commented Oct 10, 2025

Yes, I have edited the description above to refer to #5750

@wenzeslaus wenzeslaus changed the title CI: fix raster/r.texture/testsuite/test_texture.py on MacOS (G84) CI: Fix r.texture test on MacOS for v8.4 Oct 10, 2025
@echoix
Copy link
Member

echoix commented Oct 10, 2025

No opinion for me, but the justification by Vashek is fine: the numbers are probably wrong, so one wrong number for another is equivalent.

@echoix echoix changed the title CI: Fix r.texture test on MacOS for v8.4 CI: Fix r.texture test on macOS for v8.4 Oct 15, 2025
@echoix echoix merged commit 4f1c5f3 into OSGeo:releasebranch_8_4 Oct 15, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration macOS macOS specific module Python Related code is in Python raster Related to raster data processing tests Related to Test Suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants