Skip to content

i.ortho.rectify: Fix Copy into fixed size buffer issue in main.c #6466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

i.ortho.rectify: Fix Copy into fixed size buffer issue in main.c #6466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e8cf6a0
Fix Copy into fixed size buffer issue
Oct 7, 2025
e12254e
Update imagery/i.ortho.photo/i.ortho.rectify/main.c
ShubhamDesai Oct 7, 2025
44acd45
Update imagery/i.ortho.photo/i.ortho.rectify/main.c
ShubhamDesai Oct 7, 2025
643e199
Update imagery/i.ortho.photo/i.ortho.rectify/main.c
ShubhamDesai Oct 7, 2025
4aedeea
Update imagery/i.ortho.photo/i.ortho.rectify/main.c
ShubhamDesai Oct 7, 2025
94dc654
add CID
Oct 7, 2025
5641017
Merge remote-tracking branch 'origin/issue_265' into issue_265
Oct 7, 2025
c3bf693
Update imagery/i.ortho.photo/i.ortho.rectify/target.c
ShubhamDesai Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions imagery/i.ortho.photo/i.ortho.rectify/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,12 @@ int main(int argc, char *argv[])
interpolate = menu[method].method;

G_strip(grp->answer);
strcpy(group.name, grp->answer);
strcpy(extension, ext->answer);
if (G_strlcpy(group.name, grp->answer, sizeof(group.name)) >=
sizeof(group.name))
G_fatal_error(_("Group name <%s> is too long"), grp->answer);
if (G_strlcpy(extension, ext->answer, sizeof(extension)) >=
sizeof(extension))
G_fatal_error(_("Extension <%s> is too long"), ext->answer);

seg_mb = NULL;
if (mem->answer) {
Expand Down Expand Up @@ -281,7 +285,10 @@ int main(int argc, char *argv[])
if (!ref_list[i])
continue;

strcpy(result, group.group_ref.file[i].name);
if (G_strlcpy(result, group.group_ref.file[i].name,
sizeof(result)) >= sizeof(result))
G_fatal_error(_("Map name <%s> is too long"),
group.group_ref.file[i].name);
strcat(result, extension);

if (G_legal_filename(result) < 0)
Expand Down
10 changes: 6 additions & 4 deletions imagery/i.ortho.photo/i.ortho.rectify/target.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,13 @@ int get_target(char *group)
snprintf(buf, sizeof(buf),
_("Mapset <%s> in target project (location) <%s> - "), mapset,
location);
strcat(buf, stat == 0 ? _("permission denied") : _("not found"));
(void)G_strlcat(buf, stat == 0 ? _("permission denied") : _("not found"),
sizeof(buf));
error:
strcat(buf, "\n");
strcat(buf, _("Please run i.target for group "));
strcat(buf, group);
(void)G_strlcat(buf, "\n", sizeof(buf));
(void)G_strlcat(buf, _("Please run i.target for group "), sizeof(buf));
if (G_strlcat(buf, group, sizeof(buf)) >= sizeof(buf))
G_fatal_error(_("Internal error: error message too long"));
G_fatal_error("%s", buf);
return 1; /* never reached */
}
Loading