CMake: Fix LAPACKE detection on Debian Bookworm (Debian 12) #6365

Dasux · 2025-09-17T08:28:52Z

This pull request is an attempt to fix #6364.

Fix-1: LAPACKE detection error by CMake

The Bug

on debian 12 (bookworm)... building GRASS failed with the following error
Could NOT find LAPACKE (missing: HAVE_LAPACKE_DGESV)

Even though liblapacke-dev and libopenblas-dev were installed, CMake couldn’t detect LAPACKE because the check relied on check_symbol_exists(), which doesn’t actually link against liblapacke.so.

Debugging

created a build directory and ran the following

mkdir build && cd build
cmake ..

confirmed headers and library exists:

ls /usr/include/lapacke.h
ls /usr/lib/x86_64-linux-gnu/liblapacke.so

wrote a tiny test program

#include <lapacke.h>
#include <stdio.h>

int main() {
    printf("LAPACKE_dgesv is here: %p\n", LAPACKE_dgesv);
    return 0;
}

compile

gcc test_lapacke.c -o test_lapacke -llapacke -llapack -lblas
./test_lapacke.c

output LAPACKE_dgesv is here: 0x7fe4658c1320
This ensures that lapacke exists and is working fine

The Fix

Edited cmake/find_scripts/FindLAPACKE.cmake to replace the header-only check with a proper library check.
Initially it was

include(CheckSymbolExists)
set(CMAKE_REQUIRED_LIBRARIES ${LAPACKE_LIBRARIES})
set(CMAKE_REQUIRED_INCLUDES ${LAPACKE_INCLUDEDIR})
set(CMAKE_REQUIRED_QUIET ${LAPACKE_FIND_QUIETLY})
check_symbol_exists(LAPACKE_dgesv "lapacke.h" HAVE_LAPACKE_DGESV)
unset(CMAKE_REQUIRED_LIBRARIES)
unset(CMAKE_REQUIRED_INCLUDES)
unset(CMAKE_REQUIRED_QUIET)

Which was changed to

include(CheckLibraryExists)
# Look for include and library
find_path(LAPACKE_INCLUDE_DIR lapacke.h)
find_library(LAPACKE_LIBRARIES lapacke)

if(LAPACKE_INCLUDE_DIR AND LAPACKE_LIBRARIES)
    set(CMAKE_REQUIRED_INCLUDES ${LAPACKE_INCLUDE_DIR})
    set(CMAKE_REQUIRED_LIBRARIES ${LAPACKE_LIBRARIES})
    check_library_exists(lapacke LAPACKE_dgesv "" HAVE_LAPACKE_DGESV)
endif()

unset(CMAKE_REQUIRED_LIBRARIES)
unset(CMAKE_REQUIRED_INCLUDES)

Fix-2: Automated Script for installing build dependencies

The scripts are in setup_grass_dev.sh and setup_grass_extra.sh.

echoix · 2025-09-17T09:17:45Z

INSTALL.md

+```
+```
+```
+```
+```


Is this valid markdown markup?

yes--- it's my first time using markdown--- ill resolve it asap

No worries ;) caught my eye when waking up

thanks for the heads up--- ive resolved them 🙂

echoix · 2025-09-17T09:18:59Z

INSTALL.md

+    r-base-dev \
+    python3-termcolor \
+    libglu1-mesa-dev libgl1-mesa-dev \
+    subversion```


I think a multiline code block finishes with the ticks on another line

alright----

echoix · 2025-09-17T09:19:28Z

INSTALL.md

 ## Authors

 Markus Neteler and the GRASS Development Team
+


Extra change?

thats probably just a white space--- must've hit enter when editing the file

echoix · 2025-09-17T09:54:07Z

INSTALL.md

 - [Guide to contributing on GitHub](./doc/development/github_guide.md)

+
+## (N) Debian Bookworm (Debain 12) 


Suggested change

## (N) Debian Bookworm (Debain 12)

## (N) Debian Bookworm (Debian 12)

wenzeslaus · 2025-09-17T12:20:52Z

This is good, but the scripts need to be more organized. We are already building Docker images. Can we reuse or connect with that? So, there would be one single place and it would be tested regularly. Also, the installation instructions can use the script making maintenance easier.

Dasux · 2025-09-17T14:11:34Z

This is good, but the scripts need to be more organized. We are already building Docker images. Can we reuse or connect with that? So, there would be one single place and it would be tested regularly. Also, the installation instructions can use the script making maintenance easier.

Thanks for the feedback! That makes sense — keeping scripts in one place and reusing the Docker setup would definitely make things more consistent. Could you point me to the Docker build scripts so I can take a look at how this could fit in?

echoix · 2025-09-17T14:27:14Z

This is good, but the scripts need to be more organized. We are already building Docker images. Can we reuse or connect with that? So, there would be one single place and it would be tested regularly. Also, the installation instructions can use the script making maintenance easier.

Thanks for the feedback! That makes sense — keeping scripts in one place and reusing the Docker setup would definitely make things more consistent. Could you point me to the Docker build scripts so I can take a look at how this could fit in?

The folder is docker/debian

nilason · 2025-09-17T15:59:08Z

INSTALL.md

 - [Guide to contributing on GitHub](./doc/development/github_guide.md)

+
+## (N) Debian Bookworm (Debian 12) 


We have a dedicated page for this kind of information: https://grasswiki.osgeo.org/wiki/Compile_and_Install. There are lots of platforms to give instructions to... in my opinion this is not the place. Maybe we can link to that page (and update it wherever needed).

I wasnt aware of this--- i'll remove this section from the docs

Additionally-- i think it would be better if I added the missing dependencies (if any) to docker/debian.... as @wenzeslaus suggested ----- a single script handling such things would be better

any thoughts?

nilason · 2025-09-17T16:09:08Z

cmake/find_scripts/FindLAPACKE.cmake

+]]
+
+
+include(CheckLibraryExists)


The current implementation (admittedly with plenty of room to improve) is based on search for pkg-config files. Also Debian installs *.pc files for openblas (and cblas, lapacke): openblas.pc, blas-openblas.pc, lapack-openblas.pc. That should be enough. We should initially explore what is possibly missing for that to work.

It is possible to add configuration, e.g.: -DLAPACKE_PKGCONFIG=lapack-openblas.

I tried your suggestion — cmake .. now runs smoothly ( i must’ve overlooked that earlier).

However, when I run make install, I still hit errors related to MAPSET PERMANENT - permission denied. It seems the build process expects a valid GRASS location/mapset for thumbnail generation, which fails if none exists.

Do you think this should be handled in the build system (e.g. skipping thumbnails when no mapset is available), or is this more of a local environment setup issue?

Difficult to say without the log file.

Forgot to mention this page: https://grasswiki.osgeo.org/wiki/Compile_and_Install_With_CMake

echoix · 2025-10-07T02:31:28Z

Our Dockerfiles now use Debian 13, a change since this PR was opened

Improved documentation and fixed LAPACKE detection failure

4d29f35

github-actions bot added docs markdown Related to markdown, markdown files CMake labels Sep 17, 2025

echoix requested changes Sep 17, 2025

View reviewed changes

Resolved markdown issues in INSTALL.md

b88e3d9

echoix requested changes Sep 17, 2025

View reviewed changes

fixed typo in 'Debian'

a155f6c

nilason requested changes Sep 17, 2025

View reviewed changes

Merge branch 'main' into improve_debian_install_docs

351f5ba

		- [Guide to contributing on GitHub](./doc/development/github_guide.md)


		## (N) Debian Bookworm (Debain 12)

	## (N) Debian Bookworm (Debain 12)
	## (N) Debian Bookworm (Debian 12)

Uh oh!

CMake: Fix LAPACKE detection on Debian Bookworm (Debian 12) #6365

Are you sure you want to change the base?

CMake: Fix LAPACKE detection on Debian Bookworm (Debian 12) #6365

Uh oh!

Conversation

Dasux commented Sep 17, 2025

Fix-1: LAPACKE detection error by CMake

The Bug

Debugging

The Fix

Fix-2: Automated Script for installing build dependencies

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wenzeslaus commented Sep 17, 2025

Uh oh!

Dasux commented Sep 17, 2025

Uh oh!

echoix commented Sep 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dasux Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

echoix commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Dasux Sep 17, 2025 •

edited

Loading