gui: Resolve region mismatch handling and command error visibility in history browser #5456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudhanshu112233shukla
commented
Mar 26, 2025
sudhanshu112233shukla
commented
- Match saved regions and add update button Closes [Feat] wxGUI/history: Displaying region name if stored #5283
- Display error messages in red for failed commands Closes [Feat] wxGUI/history: Displaying Error Messages for Failed Commands #5282
github-actions
bot
added
GUI
petrasovaa
reviewed
Mar 27, 2025
gui/wxpython/history/browser.py
Outdated
| StaticText( | ||
| """Update general info box with error message if command failed.""" | ||
|
|
||
| self.sizer_general_info.Clear(True) |
There was a problem hiding this comment.
Not sure what is going on with your IDE, but the indentation is incorrect.
There was a problem hiding this comment.
@petrasovaa I think it will work now ....
|
To be clear, the code is completely broken. If you intend to contribute this code, please test the same code locally first, and don't just guess what might work. The same goes for all your other PRs. |
…) (OSGeo#5283) - Added region name display in history browser - Added error message display in history browser - Added test suite for both features
|
@petrasovaa i have tested it its working , can you review it once . |
|
Each PR should deal with one thing - there are two completely different things... Besides, the indentation is incorrect, there are some changes in code only changing the indentation.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.