-
Notifications
You must be signed in to change notification settings - Fork 13
Brand synchronization #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I liked the previous font better or something similar to that sort of simpler letters (I do not know how they are called); this one does not seem to align with GRASS website style nor with the font in our logo. |
The font issues was a bug in the config should be fixed now. Will post an update screenshot when I'm at my computer. |
I've added the start to a style guide partially as a way to check edge cases. Set it up locally you need to add an The file should include the following PYTHONDEVMODE=1
QUARTO_PROFILE=local Now when you run quarto preview Then navigate to local site at
GRASS Quarto Design Guide |
@petrasovaa please review when you are able. Here are screenshots from the updated sections. When title-block-banner: trueButtonsModified Callouts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the freeze, it's being built now in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we should add _freeze/
to .gitignore then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I am not sure I understand the plan with the Team Documents and the guide.
Also, I thought we decided on sentence case for headings, no?
@@ -0,0 +1,23 @@ | |||
grass: | |||
name: GRASS | |||
version: 8.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why version? We would need to keep it updated. I would remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be useful to have the latest version as a variable so if it is mentioned we can do a quick update.
@@ -0,0 +1,9 @@ | |||
--- | |||
title: Team Documents | |||
description: Learn about sytling your GRASS tutorial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Learn about sytling your GRASS tutorial | |
description: Learn about styling your GRASS tutorial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used to show what the different listing styles look like in styling.qmd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be useful, but it shows up as one of the tutorials, which is confusing. Also it doesn't include the language content tabs, which we use in some tutorials and should be probably demonstrated here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you do this part from the PR?
I've added a style guide partially as a way to check edge cases. Set it up locally you need to add an _environment.local
file to the root of the project.
The file should include the following
PYTHONDEVMODE=1
QUARTO_PROFILE=local
Now when you run quarto preview
the content in content/tests
will render with the project.
quarto preview
Then navigate to local site at content/tests/styling.html
http://localhost:5753/content/tests/styling.html
Remember to update your port number
@@ -0,0 +1,932 @@ | |||
--- | |||
title: GRASS Quarto Design Guide | |||
description: Adopted from Quarto Documentatoin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Adopted from Quarto Documentatoin | |
description: Adopted from Quarto Documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petrasovaa thanks for the feedback. I've addressed your comments. My todo is to remove the _freeze files, and I'll add a section to show the language selection tabs.
Synchronizing GRASS brand with Quarto
Updated PR Details
I've added a style guide partially as a way to check edge cases. Set it up locally you need to add an
_environment.local
file to the root of the project.The file should include the following
Now when you run
quarto preview
the content incontent/tests
will render with the project.Then navigate to local site at
content/tests/styling.html
http://localhost:5753/content/tests/styling.html
GRASS Quarto Design Guide
Orginial Info
The formatting is close but still requires some additional tweaks.