Skip to content

Brand synchronization #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Brand synchronization #12

wants to merge 23 commits into from

Conversation

cwhite911
Copy link
Contributor

@cwhite911 cwhite911 commented Jan 21, 2025

Synchronizing GRASS brand with Quarto

Updated PR Details

I've added a style guide partially as a way to check edge cases. Set it up locally you need to add an _environment.local file to the root of the project.

The file should include the following

PYTHONDEVMODE=1
QUARTO_PROFILE=local

Now when you run quarto preview the content in content/tests will render with the project.

quarto preview

Then navigate to local site at content/tests/styling.html

http://localhost:5753/content/tests/styling.html

Remember to update your port number

GRASS Quarto Design Guide

Orginial Info

I've added the _brand.yml file for us to use once we update Quarto to >=1.7

The formatting is close but still requires some additional tweaks.

@wenzeslaus wenzeslaus marked this pull request as draft March 18, 2025 20:13
@cwhite911
Copy link
Contributor Author

image

@cwhite911 cwhite911 marked this pull request as ready for review April 11, 2025 04:33
@cwhite911
Copy link
Contributor Author

cwhite911 commented Apr 11, 2025

image

@veroandreo
Copy link

I liked the previous font better or something similar to that sort of simpler letters (I do not know how they are called); this one does not seem to align with GRASS website style nor with the font in our logo.

@cwhite911
Copy link
Contributor Author

I liked the previous font better or something similar to that sort of simpler letters (I do not know how they are called); this one does not seem to align with GRASS website style nor with the font in our logo.

The font issues was a bug in the config should be fixed now. Will post an update screenshot when I'm at my computer.

@cwhite911
Copy link
Contributor Author

I've added the start to a style guide partially as a way to check edge cases. Set it up locally you need to add an _environment.local file to the root of the project.

The file should include the following

PYTHONDEVMODE=1
QUARTO_PROFILE=local

Now when you run quarto preview the content in content/tests will render with the project.

quarto preview

Then navigate to local site at content/tests/styling.html

http://localhost:5753/content/tests/styling.html

Remember to update your port number

GRASS Quarto Design Guide

Screenshot 2025-05-06 at 22-16-27 GRASS Quarto Design Guide

@cwhite911
Copy link
Contributor Author

cwhite911 commented May 7, 2025

Here are some more screenshots.

Please ignore Team Documents and GRASS Quarto Design Guide in the All Tutorials section. They are only there because of the local environmental variables from _environment.local.

index

image

Getting started with GRASS

image

@cwhite911 cwhite911 changed the title Added brand file Brand synchronization May 7, 2025
@cwhite911
Copy link
Contributor Author

cwhite911 commented May 7, 2025

Updated views:

Design Guide

Screenshot 2025-05-07 at 19-57-07 GRASS Quarto Design Guide

Home Page

Note the support button in the margin header.
Screenshot 2025-05-07 at 19-59-33 Learn GRASS

@cwhite911
Copy link
Contributor Author

@petrasovaa please review when you are able.

Here are screenshots from the updated sections.

When title-block-banner: true

Screenshot from 2025-05-08 13-42-36

Buttons

Screenshot from 2025-05-08 13-42-54

Modified Callouts

Screenshot from 2025-05-08 13-43-22

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the freeze, it's being built now in CI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we should add _freeze/ to .gitignore then.

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I am not sure I understand the plan with the Team Documents and the guide.

Also, I thought we decided on sentence case for headings, no?

@@ -0,0 +1,23 @@
grass:
name: GRASS
version: 8.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why version? We would need to keep it updated. I would remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be useful to have the latest version as a variable so if it is mentioned we can do a quick update.

@@ -0,0 +1,9 @@
---
title: Team Documents
description: Learn about sytling your GRASS tutorial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Learn about sytling your GRASS tutorial
description: Learn about styling your GRASS tutorial

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used to show what the different listing styles look like in styling.qmd

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be useful, but it shows up as one of the tutorials, which is confusing. Also it doesn't include the language content tabs, which we use in some tutorials and should be probably demonstrated here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you do this part from the PR?


I've added a style guide partially as a way to check edge cases. Set it up locally you need to add an _environment.local file to the root of the project.

The file should include the following

PYTHONDEVMODE=1
QUARTO_PROFILE=local

Now when you run quarto preview the content in content/tests will render with the project.

quarto preview

Then navigate to local site at content/tests/styling.html

http://localhost:5753/content/tests/styling.html

Remember to update your port number

@@ -0,0 +1,932 @@
---
title: GRASS Quarto Design Guide
description: Adopted from Quarto Documentatoin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Adopted from Quarto Documentatoin
description: Adopted from Quarto Documentation

Copy link
Contributor Author

@cwhite911 cwhite911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petrasovaa thanks for the feedback. I've addressed your comments. My todo is to remove the _freeze files, and I'll add a section to show the language selection tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants