Silence Gemfile and key warnings #4820
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Nov 25, 2025
apps/dashboard/Gemfile
Outdated
Comment on lines
54
to
56
| gem 'ostruct' | ||
| gem 'bigdecimal' | ||
| gem 'mutex_m' |
Contributor
There was a problem hiding this comment.
Are you still seeing these? I think seeing ostruct is new, but activesupport already has these in rails 7.1, you can see them in your vendor/bundle.
Contributor
Author
There was a problem hiding this comment.
I wasn't seeing any them during tests, but I figured it was better to be overly cautious in case they were originating somewhere that wasn't being hit. I couldn't find a good way to scan the whole dashboard for depreciation warnings. I will look into them though and see if they were part of the 7.1 upgrade
johrstrom
reviewed
Nov 25, 2025
apps/dashboard/test/fixtures/widgets/recently_used_apps/sys_bc_desktop.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4147 by adding the
ostruct,bigdecimal, andmutex_mgems to the Gemfile. Also silences two duplicated key warnings by resolving the duplication.