using the converting from scalar to DynamicEvaluation #6520
Conversation
GitPaean
added
the
manual:irrelevant
|
jenkins build this opm-common=4673 please |
|
There is a failure, I am looking into this. |
|
Accidentally found that case GASCONDENSATE_VAPWAT_PRECSALT.DATA can not be run by flow. Will raise an issue. |
GitPaean
force-pushed
the
using_scalar_dynamic_evaluation
branch
from
90261fc to
b9ab0ab
Compare
GitPaean
force-pushed
the
using_scalar_dynamic_evaluation
branch
5 times, most recently
from
9f53bbb to
35a651c
Compare
GitPaean
force-pushed
the
using_scalar_dynamic_evaluation
branch
from
35a651c to
b48f753
Compare
|
jenkins build this please |
GitPaean
force-pushed
the
using_scalar_dynamic_evaluation
branch
from
b48f753 to
90c98a9
Compare
| EvalWell out(in.value()); | ||
| for(int eqIdx = 0; eqIdx < Indices::numEq;++eqIdx) { | ||
| out.setDerivative(eqIdx, in.derivative(eqIdx)); | ||
| out.setDerivative(eqIdx, in.derivative(eqIdx), primary_variables_.numWellEq() + Indices::numEq); |
There was a problem hiding this comment.
I believe this change is correct, but the old code seems a little clearer to me here.
There was a problem hiding this comment.
because the out is initialized with a scalar. It does not carry derivatives.
So when we setDerivative, we have to specify the number of the derivatives.
atgeirr
left a comment
atgeirr
left a comment
There was a problem hiding this comment.
Looks good to me, only nitpick is the extendEval() issue commented on. If you prefer the new code there I do not insist on reverting it.
atgeirr
changed the title
GitPaean
force-pushed
the
using_scalar_dynamic_evaluation
branch
from
90c98a9 to
4e34efb
Compare
|
jenkins build this please |
|
I could not reproduce the failure locally. Will ask jenkins again. |
|
jenkins build this please |
|
The jenkins is green now. It looks like that it was some hiccups. Since it is approved and I am getting the PR in now. |
2 participants
using the development from OPM/opm-common#4673 .