StressEquil: change to storing tensors as SymmTensor #4698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akva2
added
the
manual:irrelevant
|
jenkins build this please |
akva2
force-pushed
the
change_symmtensor
branch
from
02103b9 to
763cd14
Compare
|
jenkins build this please |
|
This is probably a good idea and it does simplify the interfaces. I'll hold off a little on approving/merging this, though, because I need to be sure that the downstream call sites in https://github.com/OPM/opm-flowgeomechanics have been properly vetted and that there's a PR in place to update them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sits on top of #4697