Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependabot config to exclude babel and pylint releases #1384

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

petechd
Copy link
Contributor

@petechd petechd commented Jun 5, 2024

What is the context of this PR?

We cannot merge any v3 upgrades for pylint library. It will cause an import error in linting since pylint-quotes library is not maintained and not compatible with the latest v3 pylint release that we are trying to update here. Link to the issue raised in pylint-quotes repo: edaniszewski/pylint-quotes#29. Here's an PR that fixes it: edaniszewski/pylint-quotes#28 (still not merged). We want to ignore any pylint updates for the time being.
babel library has to also stay on v2.14.0 until Welsh translations issue in v2.15.0 is investigated and fixed.

How to review

You can check in a fork if babel and pylint are ignored whenever Dependabot PR is raised.

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@petechd petechd marked this pull request as ready for review June 5, 2024 09:06
Copy link
Contributor

@Yuyuutsu Yuyuutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on Fork. Fork Dependabot PR. here

@petechd petechd merged commit aa6c6c9 into main Jun 7, 2024
16 checks passed
@petechd petechd deleted the update-dependabot-config branch June 7, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants