Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runner to use poetry package manager #1284

Merged
merged 135 commits into from
Apr 12, 2024
Merged

Conversation

Yuyuutsu
Copy link
Contributor

@Yuyuutsu Yuyuutsu commented Dec 28, 2023

What is the context of this PR?

Update Runner to use poetry package manager.
Other related changes made:

  • Packages have been updated.
  • Fixed any new type hinting errors found
  • Flake8 Config has been updated to accommodate new black update. Black documentation here

Pylint has been pinned due to problems with how Pylint interacts with pylint_quotesin versions3.*.*. There has been an issue raised and a PR to resolve the issue with pylint_quotes, but owner of the repoistory has not merged yet. See issue here

We will now use poetry-plugin-dotenv plugin to load dotenvs.
Also added poetry-plugin-up plugin to manage pyproject.toml dependencies The installation guide of the plugins have been added to the ReadMe file.

How to review

  • Github actions works as expected with Poetry
  • Make Commands work as expected
  • Dockerfile Builds
  • if Runner application is working as expected
  • Tests run as expected
  • New Installation and setup works

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@Yuyuutsu
Copy link
Contributor Author

.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@MebinAbraham MebinAbraham removed the dont merge Don't merge this PR label Apr 3, 2024
@Yuyuutsu Yuyuutsu merged commit d657a2e into main Apr 12, 2024
16 checks passed
@Yuyuutsu Yuyuutsu deleted the update-runner-to-use-poetry branch April 12, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants