rule: Don't drop flow if rule matches on packet properties. #9618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the logic used to determine the disposition of a flow/packet. If the rule contains packet match properties, the flow shouldn't be dropped. Issue: 5578
|
I'm reworking the s-v PR. The failures seem related to a recent merge about deduplicating PCAPs. |
|
Jeff, this PR also seems to need 0f097ac |
|
Continued in #9618 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the logic used to determine the disposition of a flow/packet.
If the rule contains packet match properties, the flow shouldn't be dropped.
Link to redmine ticket: 5578
Describe changes:
dropaction, check if the rule applies to packet properties.Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis thepull request number.
Alternatively,
SV_BRANCHmay also be a link to anOISF/suricata-verify pull-request.
SV_BRANCH=OISF/suricata-verify#1424