Analyze DPDK hugepages and be more user-friendly with non-existing user and check for shutdown before accessing Unix sockets v5 #9549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 4, 2023 16:17
If a user allocates too many hugepages and those are largely not used then Suricata suggests that the user can lower the amount of hugepages and therefore save memory for other purposes. Ticket: OISF#5966
If a user doesn't allocate/allocates too little hugepages, Suricata fails to start and outputs a hint to increase number of hugepages (if enabled). Ticket: OISF#5966
FatalError replaced function return because the caller (suricata.c) did not handle the return value.
Make sure Suricata is in the running state before you attempt to execute commands on the Unix sockets. Likely with a longer time span between the initial shutdown command and actual closing of Unix sockets resulted in an error of invalid file descriptors. Ticket: OISF#6272
|
OISF/suricata-verify#1358 will need to be rebased to have a chance at a passing CI |
|
Continues in #9562 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #9466
PR is a combination of:
https://redmine.openinfosecfoundation.org/issues/6278
https://redmine.openinfosecfoundation.org/issues/5966
https://redmine.openinfosecfoundation.org/issues/6272
Describe changes:
To use a pull request use a branch name like pr/N where N is the
pull request number.
Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.
SV_REPO=
SV_BRANCH=pr/1358
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=