Multipart mime 3487 v18 #9424
Multipart mime 3487 v18 #9424
Conversation
Accepts escaped quote in escaped string
as tested by suricata-verify
to be squashed in previous commit
to be squashed
|
ERROR: ERROR: QA failed on SURI_TLPW1_files_sha256. Pipeline 15791 |
| @@ -0,0 +1,605 @@ | |||
| /* Copyright (C) 2021 Open Information Security Foundation | |||
There was a problem hiding this comment.
2023? Or did you write this initially in 2021?
There was a problem hiding this comment.
I wrote it in 2021 ...
| escaping = true; | ||
| } else { | ||
| if input[i] == b'"' && !escaping { | ||
| return Ok((&input[i + 1..], &input[..i])); |
There was a problem hiding this comment.
Could unicode mess with this. I recently ran into this: jasonish/suricatax-rule-parser-rs@d77c4e3
There was a problem hiding this comment.
This is a buffer &[u8] not a string, so there is no need to worry about unicode, right ?
|
We should probably think about the name space in new code. The Also, since these Rust functions are part of the But maybe we should wait for some further discussion on this. |
Let me know if I need to do more renaming :-) |
|
Replaced by #9436 |
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3487
Describe changes:
Follows #9038 with rebase and squash
Still to do by me :
SV tests from unit tests in OISF/suricata-verify#1369