Detect flow pkts 6164 v3 #9062
Closed
Detect flow pkts 6164 v3 #9062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Information: QA ran without warnings. Pipeline 14765 |
victorjulien
requested changes
Jun 27, 2023
src/detect-flow-pkts.c
Outdated
| if (p->flow == NULL) { | ||
| return 0; | ||
| } | ||
| uint32_t nb = p->flow->tosrcbytecnt; |
There was a problem hiding this comment.
And CI is green :-/
There was a problem hiding this comment.
Argh, that looks like a bug in clang Wimplicit-int-conversion
If I change u32 to u16, I get as expected
detect-flow-pkts.c:268:28: warning: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'uint16_t' (aka 'unsigned short') [-Wimplicit-int-conversion]
uint16_t nb = p->flow->todstbytecnt;
But no warning with downcast from u64 to u32...
Ticket: OISF#6164 flow.pkts_toclient flow.pkts_toserver flow.bytes_toclient flow.bytes_toserver
catenacyber
force-pushed
the
detect-flow-pkts-6164-v3
branch
from
c3f3a47 to
a99516f
Compare
|
Replaced by #9095 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6164
Describe changes:
OISF/suricata-verify#1267
#9051 with review taken into account