Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http uri spaces 2881 v10 #7443

Closed
wants to merge 2 commits into from

Conversation

catenacyber
Copy link
Contributor

@catenacyber catenacyber commented May 31, 2022

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2881

Describe changes:

  • configures libhtp to allow spaces in URIs

Modifies #7352 with rebase to get CI green

suricata-verify-pr: 837

OISF/suricata-verify#837

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #7443 (1bde6da) into master (43d28f2) will decrease coverage by 0.03%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master    #7443      +/-   ##
==========================================
- Coverage   75.88%   75.84%   -0.04%     
==========================================
  Files         657      657              
  Lines      189473   189490      +17     
==========================================
- Hits       143775   143721      -54     
- Misses      45698    45769      +71     
Flag Coverage Δ
fuzzcorpus 60.43% <78.57%> (-0.17%) ⬇️
suricata-verify 52.07% <71.42%> (+0.09%) ⬆️
unittests 60.89% <15.38%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

ERROR:
ERROR: Invalid Signature config error in tlpr1_asan_cfg QA test

ERROR: QA failed on tlpr1_asan_cfg.

Pipeline 7669

@catenacyber
Copy link
Contributor Author

@ct0br0 @pevma I guess QA lab needs to update ET signatures again cf OISF/suricata-verify#836

@suricata-qa
Copy link

ERROR:
ERROR: Invalid Signature config error in tlpr1_asan_cfg QA test

ERROR: QA failed on tlpr1_asan_cfg.

Pipeline 7669
WARNING: THERE IS A KNOWN BAD BASELINE WITH PACKET DROPS. BE MINDFUL OF ANY RESULTS.

@ct0br0
Copy link

ct0br0 commented Aug 31, 2022

Been having issues with notifications. Just saw this, will re-run as it hasn't changed and that pipe is old.

@suricata-qa
Copy link

ERROR:
ERROR: Invalid Signature config error in tlpr1_asan_cfg QA test

ERROR: QA failed on tlpr1_asan_cfg.

Pipeline 9101

@ct0br0
Copy link

ct0br0 commented Sep 12, 2022

Our current version and the latest version of this SID are the same. Parsing issue must be on our side.

@victorjulien
Copy link
Member

Waiting for a good moment to merge this as it requires a QAlab rebaseline.

@catenacyber
Copy link
Contributor Author

Replaced by #7915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants