Dynamic alprotos : make SNMP totally dynamic v4 #12414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CID 1640392 Would happen only if we reached 15 protocols handling files
Ticket: 5053 Do not asume that we know the number of alprotos at the end of AppLayerNamesSetup, but make arrays allocated by later AppLayerProtoDetectSetup dynamic so that it can be reallocated from AppLayerParserRegisterProtocolParsers This helps have a single entry point for a protocol like SNMP
So that we do not have to know g_alproto_max to register dynamically a new protocol from its name
Ticket: 5053 Move enum OutputJsonLogDirection and struct EveJsonTxLoggerRegistrationData from C to rust
and cast and also remove unneeded mut and rustfmt
Ticket: 5053
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12414 +/- ##
==========================================
+ Coverage 80.63% 80.77% +0.14%
==========================================
Files 918 918
Lines 258696 258734 +38
==========================================
+ Hits 208598 208992 +394
+ Misses 50098 49742 -356
Flags with carried forward coverage won't be shown. Click here to find out more. |
catenacyber
changed the title
|
Information: QA ran without warnings. Pipeline 24248 |
| LOG_DIR_FLOW_TOSERVER = 3, | ||
| } | ||
|
|
||
| // Also defined in output.h |
There was a problem hiding this comment.
can the definition just be here?
There was a problem hiding this comment.
Forgot to remove the comment, the definition is now just in rust
|
Next in #12420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5053
Describe changes:
#12408 with removing duplicate definitions between C and rust, just moving to rust see commit 1f75d01
Already quite a few things going on here, so stopping here before adding the example of a template plugin