Protodetect probing mask32 7437 v3 #12403
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7495 We want to finish also if we tested all the expected protocols in mask, or if we tested even more. There can be one more protocol coming from pe0, which can be the protocol already found in the other direction.
Ticket: 7469
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12403 +/- ##
==========================================
- Coverage 80.63% 80.63% -0.01%
==========================================
Files 917 917
Lines 258687 258687
==========================================
- Hits 208601 208590 -11
- Misses 50086 50097 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7495
https://redmine.openinfosecfoundation.org/issues/7469
(blocking https://redmine.openinfosecfoundation.org/issues/7437 )
Describe changes:
SV_BRANCH=OISF/suricata-verify#2200
#12307 with simpler change that will be backported
This will require a QA baseline update as highlighted by the SV test