Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: fix clippy lint warnings (keep comments) #12284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasonish
Copy link
Member

Fix vector lint issues:

  • same_item_push
  • vec_init_then_push

Fix vector lint issues:
- same_item_push
- vec_init_then_push
@jasonish jasonish mentioned this pull request Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.23%. Comparing base (0e4faba) to head (3630289).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #12284    +/-   ##
========================================
  Coverage   83.22%   83.23%            
========================================
  Files         912      912            
  Lines      257311   257625   +314     
========================================
+ Hits       214154   214427   +273     
- Misses      43157    43198    +41     
Flag Coverage Δ
fuzzcorpus 61.09% <ø> (+0.01%) ⬆️
livemode 19.39% <ø> (-0.13%) ⬇️
pcap 44.41% <ø> (+0.05%) ⬆️
suricata-verify 62.86% <ø> (+0.02%) ⬆️
unittests 59.18% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants