Detect log alert tx one 7199 v8 #12255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7199 Uses a config parameter detect.guess-applayer-tx to enable this behavior (off by default) This feature is requested for use cases with signatures not using app-layer keywords but still targetting application layer transactions, such as pass/drop rule combination, or lua usage. This overrides the previous behavior of checking if the signature has a content match, by checking if there is only one live transaction, in addition to the config parameter being set.
to better reflect their true meaning
catenacyber
requested review from
jasonish,
jufajardini,
victorjulien and
a team
as code owners
|
Argh, I needed to rebase the SV PR to get green CI |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12255 +/- ##
==========================================
- Coverage 83.21% 83.21% -0.01%
==========================================
Files 912 912
Lines 257183 257192 +9
==========================================
- Hits 214025 214019 -6
- Misses 43158 43173 +15
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Dec 10, 2024
|
Information: QA ran without warnings. Pipeline 23768 |
Merged
|
Merged in #12259, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7199
Also solves https://redmine.openinfosecfoundation.org/issues/7350
May also solve https://redmine.openinfosecfoundation.org/issues/7406
Follow up on @jufajardini work - #12243
just to adjust the terminology we're trying to agree upon also in the commit message
SV_BRANCH=OISF/suricata-verify#2172