Mark flow elephant/v3 #12237
Draft
Mark flow elephant/v3 #12237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add user defined elephant flow definition based on rate of bytes easily configurable in suricata.yaml. 2. Add an elephant flow counter. Feature 5647
This brings us down from 2 holes of 2 bytes and 4 bytes to one hole of 5 bytes. There may be more room for improvement.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12237 +/- ##
=======================================
Coverage 83.18% 83.18%
=======================================
Files 912 912
Lines 257169 257185 +16
=======================================
+ Hits 213914 213949 +35
+ Misses 43255 43236 -19
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
reviewed
Dec 6, 2024
| # number of bytes a flow has seen in either direction divided by the time a | ||
| # flow has been alive. | ||
| elephant-flow: | ||
| rate: 1000000 |
There was a problem hiding this comment.
to me a rate needs a time element, how would that be expressed here?
There was a problem hiding this comment.
yeah. will make it take two args instead: bytes and seconds just like the flow.rate keyword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/5647
Previous PR: #12123
Changes since v2:
Flowstruct (still a WIP)