output/http: log invalid status as a string #12164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7311 If response_status_number is not a valid poisitive integer, we should not try to parse it again, and fail again, but just log the raw string.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12164 +/- ##
==========================================
+ Coverage 49.81% 49.83% +0.02%
==========================================
Files 909 909
Lines 257904 257900 -4
==========================================
+ Hits 128467 128537 +70
+ Misses 129437 129363 -74
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 23586 |
|
Information: QA ran without warnings. Pipeline 23624 |
jasonish
reviewed
Dec 2, 2024
Comment on lines
+2017
to
+2019
| "status_string": { | ||
| "type": "string" | ||
| }, |
There was a problem hiding this comment.
nit: would be nice for all new schema entries to get a description :)
|
Next in #12203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7311
Describe changes:
Also fix integer warning on the way
SV_BRANCH=OISF/suricata-verify#2085
From #11904 in its own PR
#12128 with s/status_str/status_string/