Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/647/70x/20241127/v1 #12160

Merged
merged 1 commit into from
Nov 28, 2024
Merged

next/647/70x/20241127/v1 #12160

merged 1 commit into from
Nov 28, 2024

Conversation

victorjulien
Copy link
Member

@catenacyber
detect/transform: handle overlapping dotprefix
c3a6abf 
If there is a transform before dotprefix, it operates in place
in a single buffer, and must therefore use memmove instead of memcpy
to avoid UB.

Ticket: 7229
jasonish
jasonish approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches source PR.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23578

@victorjulien victorjulien merged commit c3a6abf into OISF:main-7.0.x Nov 28, 2024
88 checks passed
@victorjulien victorjulien mentioned this pull request Nov 28, 2024
Merged
@victorjulien victorjulien deleted the next/647/70x/20241127/v1 branch November 28, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorjulien @suricata-qa @jasonish @catenacyber