Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.0.x 7323 mqtt/v2 #12157

Closed
wants to merge 3 commits into from
Closed

7.0.x 7323 mqtt/v2 #12157

wants to merge 3 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7324

Describe changes:

#12155 + additional commit to include fix that was done in big refactor and was needed to make SV tests pass

SV_BRANCH=OISF/suricata-verify#2144

satta and others added 3 commits November 26, 2024 16:33
@satta @jasonish
mqtt: add reason code support for SUBACK
6dde3ee 
Ticket: OISF#7323
(cherry picked from commit 377d470)
@jasonish
mqtt: double-check detection directions
d474393 
Backport of commit 5d82521.

Ticket: 7323
@catenacyber
mqtt: look for a reason code in all messages
72315e4 
instead of stopping on the first message if it does not
have a reason code, like conn and conn_ack

Was fixed in master by big refactor 0a1062f
@catenacyber catenacyber mentioned this pull request Nov 27, 2024
Closed
jasonish
jasonish approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting on CI, but looks OK.

@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.18%. Comparing base (fccb328) to head (72315e4).
Report is 4 commits behind head on main-7.0.x.

Additional details and impacted files 
@@              Coverage Diff               @@
##           main-7.0.x   #12157      +/-   ##
==============================================
+ Coverage       83.13%   83.18%   +0.04%     
==============================================
  Files             922      922              
  Lines          260821   260845      +24     
==============================================
+ Hits           216826   216972     +146     
+ Misses          43995    43873     -122
Flag Coverage Δ
fuzzcorpus 64.13% <84.61%> (+0.06%) ⬆️
suricata-verify 63.35% <100.00%> (+0.04%) ⬆️
unittests 62.39% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23592

@victorjulien victorjulien mentioned this pull request Dec 1, 2024
Merged
@victorjulien
Copy link
Member

Merged in #12188, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

@jasonish jasonish jasonish approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@catenacyber @suricata-qa @victorjulien @jasonish @satta