Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next/646/20241126/v1 #12156

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

@victorjulien victorjulien requested review from jasonish and a team as code owners November 26, 2024 23:59
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.81%. Comparing base (13841c0) to head (bd7d38e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12156      +/-   ##
==========================================
+ Coverage   49.77%   49.81%   +0.03%     
==========================================
  Files         909      909              
  Lines      257884   257904      +20     
==========================================
+ Hits       128367   128467     +100     
+ Misses     129517   129437      -80     
Flag Coverage Δ
fuzzcorpus 60.95% <87.50%> (+0.01%) ⬆️
livemode 19.43% <8.33%> (-0.01%) ⬇️
pcap 44.41% <79.16%> (+0.01%) ⬆️
suricata-verify 62.74% <79.16%> (+0.05%) ⬆️
unittests 8.98% <8.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPW1_stats_chk
.app_layer.flow.ldap_tcp 1139 1255 110.18%
.app_layer.tx.ldap_tcp 1679 1911 113.82%
.app_layer.error.ldap_tcp.parser 1139 1255 110.18%

Pipeline 23561

@victorjulien victorjulien added the needs baseline update QA will need a new base line label Nov 27, 2024
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@victorjulien victorjulien merged commit bd7d38e into OISF:master Nov 27, 2024
61 checks passed
@victorjulien victorjulien deleted the next/646/20241126/v1 branch November 27, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs baseline update QA will need a new base line
Development

Successfully merging this pull request may close these issues.

5 participants